Treat platform express-checkout buttons in a bound add-to-cart form as an evidenced removal, not content loss

Abierto
#6,499 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
52/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
php
Área
backend

Línea de trabajo

Start by reading the #6492 changes and the existing accepted-removal path in SourceContentConservationReporter, then trace how commerce_add_to_cart_form is bound. Add or update fixtures for the nested Shopify payment widget and for the same widget outside a bound form. Done means the bound case emits one info removal record and no html_content_dropped finding, while the unbound case still reports content loss and the #6492 cases pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary

Since #6492, source text dropped before emitted blocks is reported as html_content_dropped and counts toward content_loss_count. On commerce storefronts, one drop recurs on every product page: the platform's dynamic-checkout / express-payment button. Conversion drops it on purpose, because the target store provides its own checkout. With no evidence attached, though, it counts as content loss and fails the import gate.

Evidence (real Shopify storefront, Dawn-family theme)

On an otherwise intact product page, #6492 reports one finding. The selector is … > product-form > form > div, with lost run ["Comprar ahora"] ("Buy it now"). The source:

<div class="product-form__buttons">
  <button type="submit" name="add">Add to cart</button>
  <div data-shopify="payment-button" class="shopify-payment-button">
    <shopify-accelerated-checkout …>
      <shopify-buy-it-now-button access-token="…" page-type="product" slot="button">
        <button type="button" class="shopify-payment-button__button shopify-payment-button__button--unbranded">Buy it now</button>
      </shopify-buy-it-now-button>
    </shopify-accelerated-checkout>
  </div>
</div>

The add-to-cart form itself converts and binds (commerce_add_to_cart_form). Only the platform payment widget is gone.

Proposal

When the add-to-cart form binds, treat a platform express-checkout widget nested in it as an evidenced removal, not silent loss:

  • Recognise it from structural or platform evidence: a known payment custom element (shopify-buy-it-now-button, shopify-accelerated-checkout, or the data-shopify="payment-button" host), or a non-submit type="button" sibling of the bound submit inside a payment-button host. Don't match on the button's text.
  • Emit an info-level commerce_platform_checkout_removed record (selector, platform, lost text) through the existing accepted-removal path in SourceContentConservationReporter.
  • It must not count toward content_loss_count.
  • If the enclosing form does not bind, keep reporting the drop as content loss.

Acceptance

  • A neutral fixture shaped like the snippet above yields 0 html_content_dropped findings and 1 info removal record, with the bound form unchanged.
  • The same widget outside a bound commerce form still yields html_content_dropped.
  • The existing #6492 negatives and positives stay green.

AI assistance: drafted by an AI agent (Claude) under operator direction.

Lenguaje dominante
PHP
Estrellas
28
Forks
5
Merge medio
2 h 53 min
PR fusionados (30 d)
938

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Automattic/blocks-engine

Todos los issues de Automattic/blocks-engine

Issues similares

Más issues de PHP

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.