ArtifactNormalizer: reaching max_files drops media still within max_media_files
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 66/100
Línea de trabajo
Start by locating ArtifactNormalizer and the loop that applies max_files and max_media_files; trace how sourceFilesBeforeGeneratedExpansions orders files before the cutoff. Use the SSI direct-artifact import scenario in the issue to check the behavior. Done means media files are admitted up to max_media_files after the non-media limit is reached, and every omitted file is still reported.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Problem
ArtifactNormalizer enforces two separate limits: max_files for non-media files and max_media_files for media. When a non-media file reaches max_files, the loop breaks. Every remaining raw file is omitted, including media files that are still within the max_media_files budget.
Inline style and script expansion (withInlineStyleFiles, withInlineScriptFiles, contentAddressInlineFiles) adds generated non-media files. sourceFilesBeforeGeneratedExpansions moves those generated files after the source files, but media files later in the list still fall behind the cutoff.
Evidence
Site: lloydlofthouse.com (Blogger). SSI direct-artifact import, which carries compiler_limits.max_files = 67; the artifact has 118 files.
- The compile records
file_limit_exceededfor 20 files, includingwebsite/media/Promotion-Cover-*.jpgandwebsite/media/mqdefault.jpg. - Those images are referenced only by related-post cards. They resolve through
MissingMediaRecoveryto the placeholder tokenasset-667e3e6f8f8bfd37. They never reach the theme or uploads in the Studio import. - With #6315 (related-card featured images), 8 of 12 card posts get that placeholder token.
resolveFeaturedImageTargetsthen drops their featured images, so those posts import without thumbnails.
Expected
Reaching the non-media max_files limit only stops non-media files. Media files keep being admitted up to max_media_files, and each dropped file is still reported.
AI disclosure: Claude (Anthropic) via Pi/Roadie in Franklin's workspace traced this with instrumented compiles of the SSI artifact and wrote this issue. Chris directed the work.
- Lenguaje dominante
- PHP
- Estrellas
- 28
- Forks
- 5
- Merge medio
- 2 h 59 min
- PR fusionados (30 d)
- 942
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de Automattic/blocks-engine
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 79/100
Automattic/blocks-engine#6318 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
Automattic/blocks-engine#4943 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
Automattic/blocks-engine#4942 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
Automattic/blocks-engine#4921 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Automattic/blocks-engine#775 ·
Los mantenedores suelen responder en 1 día
Todos los issues de Automattic/blocks-engine
Issues similares
-
kind/enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
Los mantenedores suelen responder en 1 día
-
[remove-resource] Delete Open Course Hub, Open Multicourse Hub, and Learn2 with GitSync skeletonsAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 61/100
omeka/plugin-ExhibitBuilder#160 ·