fix: coerce empty-string dialect to no-hint across native handlers (unknown dialect '' throw)

Abierto

#927 abierto el 10/6/2026 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad: 3/5
Tiempo estimado: 1-2 días
Aptitud para principiantes: 72/100

Tipo de issue: Error
Claridad: Bien especificado
Estado de actividad: Tranquilo
Stack tecnológico: typescript
Área: backend, data-engineering

Línea de trabajo

Inspecciona los handlers enumerados en packages/opencode/src/altimate/native/altimate-core.ts y packages/opencode/src/altimate/native/sql/register.ts, comenzando por la convención existente en sql/register.ts:433-434. Comprueba cada sitio de reenvío de dialecto mencionado y verifica que los dialectos representados por cadenas vacías ya no lleguen a altimate-core como una indicación de dialecto, mientras que los valores de dialecto válidos permanezcan sin cambios.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Description

Pre-existing latent bug surfaced while wiring core 0.5.1 (#925 follow-up). altimate-core throws unknown dialect '' on an empty-string dialect. Several native handlers forward params.dialect ?? undefined, so a literal "" is passed through (empty string is not nullish) and the engine throws:

packages/opencode/src/altimate/native/altimate-core.ts: Schema.fromDdl (migration), columnLineage, formatSql, extractMetadata, compareQueries, importDdl
packages/opencode/src/altimate/native/sql/register.ts: columnLineage

In the dbt review pipeline these are protected today because review/run.ts resolves config.dialect (auto-detect → fallback "snowflake") before runReview. But any direct caller using the documented default (ReviewConfig.dialect = "") would hit the throw → caught → silent degradation (e.g., column-breakage/PII-via-lineage lanes return empty).

Fix

Normalize these sites to params.dialect || undefined (coerce ""/null/undefined → undefined), matching the convention already used in sql/register.ts:433-434 and the checkEquivalence sites hardened in the parent PR. No valid dialect is falsy, so the change is behavior-neutral except for eliminating the "" throw.

Context

Independently flagged by a consensus code-review model (Gemini) during the parent PR. Kept out of the parent PR for scope discipline (those sites are not 0.5.1 functionality).

Lenguaje dominante: TypeScript
Estrellas: 813
Forks: 134
Merge medio: 2 d 2 h
PR fusionados (30 d): 67