Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Tools break when strict-schema clients fill unset optional fields with `[]`, `""` or `0`; add a registry-wide "filler-safe" contract

Abierto
  • ¿Algo no está bien?
#1,495 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
sql, typescript
Área
backend, database, testing

Línea de trabajo

Start in packages/drivers/src/query-timeout.ts around lines 36-40, where query_timeout_ms: 0 disables the deadline, then check sql-materialize.ts near line 352 where max_rows already treats 0 as unset. The issue also names the sql_execute, sql_materialize and sql_check tools. Done means a contract test that walks every registered tool schema and shows that [], "", 0 and null behave like omission. The choice between null and a separate boolean for disabling needs maintainer input before any code changes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problem

Clients that use strict JSON schemas send every property, filling unused optional ones with [], "" or 0. Individual tools have been patched one at a time, but there is no guard that "filler" behaves like an omitted field, so each new optional parameter can reintroduce the failure.

Mechanism

  • Arrays with minItems: 1 reject []; cross-field refinements (for example a limit cap tied to another parameter) reject instead of clamping.
  • Numeric fields where 0 means "disable" turn a filler value into a behaviour change: query_timeout_ms: 0 disables the safety deadline in sql_execute, sql_materialize and sql_check (packages/drivers/src/query-timeout.ts:36-40). max_rows already treats 0 as unset (sql-materialize.ts:352), so the contract is inconsistent.
  • Past instances: sql_check rejections, and a sql_execute option that rejected 14-18% of calls (212 of 1,475; 422 of 2,059; 791 of 4,368; 1,528 of 8,381 in four overlapping slices), returned only the named columns on success (1,458 of 1,495 calls, causing 448 identical re-queries and 535 s), and matched names case-sensitively (69 "Unknown column" errors).

Evidence

gpt-5.6-sol sent 0 for query_timeout_ms on 41% of its SQL calls (1,095 of 2,685; 1,215 of 2,059 in another slice), and the rejected calls appeared in every session that used the affected build. Median calls per session were 30.1 vs 19.3 and median elapsed 108 s vs 72 s.

Impact

Correctness-risk and time: filler turns safety deadlines off, and rejected calls cost a turn each.

Proposed fix

  • Add a contract test iterating every registered tool schema: set each optional property to [], "", 0 and null and require behaviour identical to omission.
  • Use null or a separate boolean, never 0, to mean "disable".
  • Clamp limits instead of rejecting; match column names case-insensitively; never narrow the projection the SQL requested.

Acceptance check

The contract test passes for all tools in the registry and fails when a tool is changed to reject an empty optional array.

Lenguaje dominante
TypeScript
Estrellas
810
Forks
121
Merge medio
1 d 12 h
PR fusionados (30 d)
94

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de AltimateAI/altimate-code

Todos los issues de AltimateAI/altimate-code

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.