(bug) No CI job runs against the merged tip of main or a release branch

Abierto Apto para principiantes
  • ¿Algo no está bien?
#6,967 2 comentarios 1 reacción 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
72/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
github-actions, shell, typescript, yaml
Área
ci-cd, testing

Línea de trabajo

Empieza por .github/workflows/12-check-unit-tests.yml y revisa sus activadores, filtros de rutas y el trabajo existente de comprobación de tipos; compara con otros workflows en .github/workflows/ si es necesario. Añade cobertura para los pushes a main y release/**, y asegúrate de que los cambios en hosting/docker-compose/** reciban cobertura de CI. Se considerará terminado cuando los pushes al commit de fusión ejecuten las comprobaciones y los cambios de Docker Compose ya no estén excluidos.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug report ci/cd devops

Found during release QA for v0.119.0.

What happens. No CI job in this repository type-checks or tests the merged tip of main or a release/** branch. Every workflow that checks application code triggers only on pull_request or workflow_dispatch. Nothing re-runs once a PR merges.

This is not theoretical: during this release, two PRs that were each individually green on their own PR checks broke the build once merged together. The merged tree failed a plain TypeScript compile with two "cannot find name" errors in the runner's turn-settlement code. That would have made every agent turn fail in production with a raw error message, and no CI signal ever caught it, because nothing ever checked the actual merged commit.

Where. .github/workflows/12-check-unit-tests.yml, which owns the pnpm run typecheck step across the web, SDK, API, services and clients packages, triggers only on pull_request and workflow_dispatch. Across the whole .github/workflows/ directory, the only workflows with a push trigger are the docs deploy, the website deploy, and the secret scan; none of them check application code. The concurrency group in 12-check-unit-tests.yml already falls back to github.ref_name, so it needs no other change to accept a push trigger.

A related gap in the same file: hosting/docker-compose/** is not in its path filters at all, so changes there get no CI coverage of any kind (no compose validation, no shellcheck), unlike hosting/kubernetes/helm/**, which is covered.

Suggested fix. Add a push trigger for main and release/** to .github/workflows/12-check-unit-tests.yml so a merge is actually verified, not just a preview of it. Separately, add path coverage (or a dedicated lightweight job) for hosting/docker-compose/**.

Lenguaje dominante
TypeScript
Estrellas
4.8k
Forks
690
Merge medio
23 h 26 min
PR fusionados (30 d)
507

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Agenta-AI/agenta

Todos los issues de Agenta-AI/agenta

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.