Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

[BUG]: Average PR Merge Time is underestimated when a merged PR has an invalid or negative duration

Abierto Apto para principiantes
  • ¿Algo no está bien?
#393 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 4 días

@g-k-s-03 ya está trabajando en esto.

Desde el 21/10/2026.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
84/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
javascript, react
Área
analytics, testing

Línea de trabajo

Lee src/hooks/useSortedData.js, centrándote en useAdvancedMetrics y en su cálculo de avgMergeHours. Añade o adapta una prueba unitaria con una duración de PR fusionado válida y otra no válida; después, ejecútala con npx vitest run. La tarea se considera completada cuando el promedio solo utiliza PRs con duraciones válidas y no negativas, mientras que el recuento de PRs fusionados mostrado permanece sin cambios.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug
Bug Description
Summary

The "Average PR Merge Time" on the Analytics page is underestimated whenever one or more merged pull requests have a duration that cannot be computed.

Root cause

In src/hooks/useSortedData.js, useAdvancedMetrics skips merged PRs with an invalid duration when summing merge times, but still counts them when dividing:

const totalMergeTime = mergedPRs.reduce((sum, pr) => {
  const duration = new Date(pr.merged_at).getTime() - new Date(pr.created_at).getTime()
  return Number.isFinite(duration) && duration >= 0 ? sum + duration : sum
}, 0)

const avgMergeHours =
  mergedPRs.length === 0
    ? 0
    : (totalMergeTime / mergedPRs.length / (1000 * 60 * 60)) || 0

A duration is treated as invalid when either timestamp cannot be parsed, or when merged_at is earlier than created_at. These PRs contribute nothing to totalMergeTime, but they are still included in mergedPRs.length. As a result, the total is divided by more PRs than it was calculated from, and the average is lower than the actual value.

Impact
  • The Analytics page shows a lower average merge time than the real value.
  • The merge-time gauge and its status label (e.g. "Fast" / "Slow") can be misleading.
  • Because the result is a plausible number rather than an error, the inaccuracy is easy to miss.

This only occurs when the PR data contains invalid or inconsistent timestamps.

Proposed fix

Track how many PRs actually contribute a valid duration, and divide totalMergeTime by that count instead of mergedPRs.length. The "Merged" count displayed in the UI does not need to change.

I'd be happy to work on this if that's okay.

Steps to Reproduce

The issue can be reproduced with a unit test against the current main branch:

import { renderHook } from '@testing-library/react'
import { useAdvancedMetrics } from './useSortedData'

it('averages only PRs with a valid duration', () => {
  const pulls = [
    { state: 'closed', created_at: '2024-01-01T00:00:00Z', merged_at: '2024-01-01T10:00:00Z' }, // 10 hours
    { state: 'closed', created_at: '2024-01-02T00:00:00Z', merged_at: 'not-a-date' },            // invalid
  ]
  const { result } = renderHook(() => useAdvancedMetrics(pulls))
  expect(result.current.avgMergeHours).toBe(10)
})

Result:
AssertionError: expected 5 to be 10

Only one PR has a valid duration (10 hours), but the total is divided by two merged PRs, giving 5 hours. The same occurs when merged_at is earlier than created_at.

Expected: the average is calculated only from PRs with a valid duration (10 hours).

Actual: PRs with an invalid duration are included in the divisor, so the average is underestimated (5 hours).

Logs and Screenshots

Test output from npx vitest run:

FAIL  src/hooks/mergeTime.check.test.js > avgMergeHours with an invalid merged PR > should average only PRs with a usable duration
AssertionError: expected 5 to be 10 // Object.is equality

- Expected
+ Received

- 10
+ 5
Environment Details
  • Branch: upstream main (as of 21 October 2026)
  • Reproduced with: npx vitest run
  • File: src/hooks/useSortedData.js (useAdvancedMetrics)
Impact

Critical - Application is unusable

Code of Conduct
  • I have joined the Discord server and will post updates there
  • I have searched existing issues to avoid duplicates
Lenguaje dominante
JavaScript
Estrellas
45
Forks
148
Merge medio
5 d 14 h
PR fusionados (30 d)
31

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de AOSSIE-Org/OrgExplorer

Todos los issues de AOSSIE-Org/OrgExplorer

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.