[BUG]: verify never checks release_hashes_sha256, so the released files are not tied to the timestamped anchor
Los mantenedores suelen responder en 1 día
@ArnabOPP ya está trabajando en esto.
Desde el 19/11/2026.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 63/100
Línea de trabajo
Start with cmd_verify in simple/ovl.py, then read the verification steps in docs/verify.md and the relevant CONTRIBUTING test guidance. Check how the anchor’s release_hashes_sha256 relates to release-hashes.txt, including the missing-field case and the exclusion fork question. Done when tests show honest inputs pass and tampered hashes or a missing field fail closed.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Summary
anchor.json commits to release_hashes_sha256, the SHA-256 of release-hashes.txt, but ovl.py verify never reads it. cmd_verify (simple/ovl.py) only requires chain_entries and chain_head_sha256 from the anchor. So the documented consistency check does not show that the downloaded files are the ones the timestamped anchor lists, which is what the README and docs/verify.md say it shows ("the released files match the timestamped record").
How I checked
anchor.jsonof the released run (release/simple-run/) has these keys:chain_entries,chain_head_index,chain_head_sha256,chain_jsonl_sha256,commit,dataset,final_model,final_state,path,release_hashes_sha256,schema.grep release_hashes_sha256 simple/*.pyfinds nothing in the v1.1.0 tag or onmain(commit 1c63518).sha256sum -c --ignore-missing release-hashes.txtonly checks files against the list it is given, so it trusts that list.
Reproduce
- Download
release/simple-run/as in the README (withoutckpt-*.pt). - Append a space to
recipe.json. - Replace the
recipe.jsonline inrelease-hashes.txtwith the new hash. - Run the README's two steps:
sha256sum -c --ignore-missing release-hashes.txtprintsrecipe.json: OK.python ovl-code/simple/ovl.py verify --run . --weights conversation-model.ptstill passes, because it never looks atrecipe.jsonor atrelease-hashes.txt.
I ran this on the real release files, on Windows with the v1.1.0 ovl.py and --no-timestamps. The timestamps cover only the bytes of anchor.json, so editing the anchor to match would break them, but nothing connects release-hashes.txt to the anchor.
Expected
verify fails closed when the files it is given are not the ones the anchor lists.
Suggested change (for discussion)
verifycompares the SHA-256 ofrelease-hashes.txtwithrelease_hashes_sha256in the anchor, and exits with an error if they differ or the field is missing.- Optionally,
verifyalso hashes the files in the run folder thatrelease-hashes.txtlists (those present, like--ignore-missing) and fails on a mismatch, so one command replacessha256sum -c. - Tests, as in CONTRIBUTING: honest input passes, and tampered input fails (a changed
recipe.jsonwith a matchingrelease-hashes.txt, a changedrelease-hashes.txt, an anchor without the field). - No change to the bits: this reads existing fields and files only.
Open questions: should an older anchor without the field fail or warn (the contributing rules say fail closed), and does the exclusion fork's anchor have the same field?
Workaround in the docs
PR #358 adds a one-line check to the documented steps (python -c that asserts the hash of release-hashes.txt equals release_hashes_sha256). It works in bash, PowerShell and CMD. This issue is about making verify do it itself.
AI use
I used Claude Code to investigate and draft this issue and to run the commands above.
- Lenguaje dominante
- Python
- Estrellas
- 26
- Forks
- 64
- Merge medio
- 2 d 11 h
- PR fusionados (30 d)
- 71
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de AOSSIE-Org/OpenVerifiableLLM
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
AOSSIE-Org/OpenVerifiableLLM#357 · 2 comentarios ·
Los mantenedores suelen responder en 1 día
-
[BUG]: Forked runs omit timestamps for inherited chain entriesPosiblemente ocupada @pavithra-r06 la tomó hace 3 días. Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
AOSSIE-Org/OpenVerifiableLLM#334 · 3 comentarios · 1 asignado ·
Los mantenedores suelen responder en 1 día
-
[BUG]: review_ckpt.py passes a run that has .pt files no chain entry coversPosiblemente ocupada @arshil42 la tomó hace 3 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
AOSSIE-Org/OpenVerifiableLLM#332 · 4 comentarios · 1 asignado ·
Los mantenedores suelen responder en 1 día
-
[BUG]: DigiCert timestamp verification fails on Windows because system_ca() ignores Windows CA bundlesPosiblemente ocupada @pavithra-r06 la tomó hace 3 días. Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
AOSSIE-Org/OpenVerifiableLLM#290 · 2 comentarios · 1 asignado ·
Los mantenedores suelen responder en 1 día
-
[BUG]: simple/ovl.py bench crashes with TypeError or ZeroDivisionError when stream yields <= 50 updatesPosiblemente ocupada @AdityasagarR123 la tomó hace 26 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
AOSSIE-Org/OpenVerifiableLLM#223 · 2 comentarios · 2 asignados ·
Los mantenedores suelen responder en 1 día
Todos los issues de AOSSIE-Org/OpenVerifiableLLM
Issues similares
-
LLMContextNode tool builders fail on nested params like `params:retrieval.max_matches`Posiblemente ocupada @Shizoqua la tomó hoy. AbiertoCommunity
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Los mantenedores suelen responder en 2 días
-
security
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
btclib-org/portanode#985 ·
Los mantenedores suelen responder en 1 día
-
[Bug]: maps skill OSRM foot/cycling returns car times (router.project-osrm.org ignores profile)Abiertocomp/tools P2 tool/skills type/bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
NousResearch/hermes-agent#158494 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
Los mantenedores suelen responder en 1 día
-
needs-format
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Niko1221/Strata#6475 · 1 comentario ·
Los mantenedores suelen responder en 6 días