Add an option to forbid planner skips so coverage can be guaranteed

Abierto
#31 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
65/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
typescript
Área
tooling

Línea de trabajo

Start by tracing the [review] configuration, planner decisions, packet-review dispatch, and coverage records described in the issue. Add the option with its default behavior, ensure disabled skips are dispatched or cause the run to fail, and verify that deterministic exclusions remain unaffected. Done means callers can enforce complete review coverage without parsing model-written skip reasons.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problem

The planner may decide a changed hunk does not need review and record a model-written reason such as "mechanical". On a 36-file diff reviewed with 0.5.6, 22 hunks were skipped this way in a single run.

For interactive use this is a sensible default - it saves calls on noise. For an automated gate it is a hole, because the decision is made by a model and there is no setting that forbids it. A caller who wants "every changed hunk was actually read by the reviewer" cannot express that today, and cannot distinguish "reviewed and clean" from "never looked at" without parsing the coverage records and re-deriving the policy itself.

The deterministic exclusions are not the problem: configured path rules and generated-file markers are auditable, and a caller can verify both independently. The planner skip is the one exclusion whose justification cannot be checked.

Proposal

A configuration switch that turns planner skips off:

[review]
allowPlannerSkips = false   # default true, current behaviour

With it disabled, every changed hunk that is not excluded by a deterministic rule is dispatched to packet review. A run that cannot do so fails rather than reporting partial coverage as complete.

An alternative, if the skip is valuable enough to keep by default: a strict coverage mode that keeps the planner's judgement but records it as an explicit, machine-readable exclusion class distinct from configured rules, so a caller can decide its own policy per class. The current coverage records are close to this already - the missing piece is the guarantee that the class is complete and the ability to refuse it.

Why it matters

Anyone using this tool as a merge gate has to answer "what did the reviewer not look at, and why". Deterministic exclusions answer that. A model-written "mechanical" does not, and it silently sets the coverage denominator. One flag makes the tool usable for gating without changing the default experience for everyone else.

Related: #29 (per-stage model selection) is the cheaper way to reach the same goal from the other side - if the packet review on trivial hunks costs little, skipping them buys less.

Lenguaje dominante
TypeScript
Estrellas
8
Forks
1
Merge medio
5 min
PR fusionados (30 d)
2

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de 0xPolygon/codegenie

Todos los issues de 0xPolygon/codegenie

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.