execution/state: an equal-value flush keeps a seeded cell Done and rewrites its status

Open
#26,514 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
47/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
go
Domain
backend, databases

Research direction

Start with execution/state/versionmap.go and trace flushCell for equal-value writes to seeded Done cells, including how status and incarnation are handled. Read the linked discussion in #26447 and the stale-read example in #26476 to understand the affected paths. Done means readers do not observe a rewritten seed status before the run is final and validate at the appropriate version.

Written by the indexing model from the issue text.

Description

When a run writes the value that a cell already holds, flushCell (execution/state/versionmap.go) keeps the cell's flag and incarnation and rewrites its status in place. Before the seal, a Done cell is a seed: a value of the block access list, or a zero balance that seeding derives. So a run that is still in flight, or one that a re-run later drops, rewrites a Done cell at the seed's version:

  • A reader does not wait for the run. The value is equal, but the status may not be the tx's final one.
  • A balance's status has readers: a deleted balance reads as a removed account. A reader can take the run's status as final, and its read validates at the seed's version.

#26447 puts the seed back when a re-run drops the write, but until then a reader sees the rewritten cell. This applies to every path. One shape with a stale read is in #26476: it does not need the rewritten status, but with #26447 the rewritten balance no longer makes the reader wait.

Found in the review of #26447 (https://github.com/erigontech/erigon/pull/26447#pullrequestreview-5958056181).

Dominant language
Go
Stars
3.6k
Forks
1.6k
Avg merge
1d 17h
Merged PRs (30d)
820

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from erigontech/erigon

All issues in erigontech/erigon

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.