db/kv/membatchwithdb: DeleteExact keeps a pair written in the same overlay

Open
#26,468 1 comment 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@yperbasis is already working on this.

Since Nov 17, 2026.

Assessment

This issue has not been assessed yet.

Description

DeleteExact on an overlay cursor does not delete a pair written in the same overlay.

  • Case: batch.Put(table, key, value) on a DupSort table, then cursor.DeleteExact(key, value).
  • deleteDup only records a marker and leaves the pair in memTx.
  • SeekBothExact returns the memory pair before it checks markers, and Flush copies the pair to the destination.
  • Direction: also remove the exact pair from memTx when recording the marker.

Present on main; found reviewing #26444.

Dominant language
Go
Stars
3.6k
Forks
1.6k
Avg merge
1d 17h
Merged PRs (30d)
820

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from erigontech/erigon

All issues in erigontech/erigon

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.