cl/phase1/network: three downloader tests keep the real-clock prefetch flake

Open
#26,422 10 comments 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@AskAlexSharov is already working on this.

Since Nov 17, 2026.

Assessment

This issue has not been assessed yet.

Description

Three backward beacon downloader tests still run on the real clock with the timing that #26414 moves into a bubble for TestBackwardBeaconDownloaderCancelsDroppedPrefetches:

  • TestBackwardBeaconDownloaderKeepsSeveralRangesInFlight
  • TestBackwardBeaconDownloaderKeepsPrefetchesWhenFirstResponseIsPartial
  • TestBackwardBeaconDownloaderKeepsPrefetchesWhenProcessingStopsAboveThem

Each uses a 20 ms response delay and the 1 ms request ticker, then asserts maxInFlight > 1. With coarse timers the first response can land before a second tick, so no prefetch starts and the assert fails, the same failure #26414 describes on Windows runners.

File: cl/phase1/network/backward_beacon_downloader_ranges_test.go. Found reviewing #26414.

Dominant language
Go
Stars
3.6k
Forks
1.6k
Avg merge
1d 17h
Merged PRs (30d)
820

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from erigontech/erigon

All issues in erigontech/erigon

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.