execmodule: combine notification metadata and state readers
Maintainers usually reply within 1 day
@yperbasis is already working on this.
Since Nov 16, 2026.
Assessment
This issue has not been assessed yet.
Description
Follow-up to #25515, related to #26013.
Dispatcher.Dispatch and prepareStateChanges accept blockTx kv.Tx and stateReader kv.TemporalGetter separately. Callers must keep these readers tied to the same announced head. Committed callers pass tx twice; overlay callers pass overlay and sd.AsSnapshotGetter(overlay).
Combine this pair into one read-view parameter using the existing kv.TemporalTx interface, which already embeds both interfaces. Update stageloop.NotificationSender, callers and tests accordingly.
The implementation must preserve the current read semantics. A plain block overlay is insufficient: its GetLatest reads the backing transaction, while the snapshot getter also sees unflushed SharedDomains writes and respects snapshot visibility and unwind bounds. Reuse or adapt the existing view implementation so block metadata and domain reads describe the same execution view, with a clear caller-owned lifetime and consistent behavior across the exposed read methods.
Keep committedTx for receipt recovery separate: it serves a different purpose and must not expose uncommitted blocks. This cleanup should preserve notification timing and recovery behavior.
Retain coverage for committed dispatch and pre-commit dispatch with updated or deleted accounts. Verify that the combined view reads the announced block metadata and matching account state, including staged unwinds, without falling back to old account values or admitting newer cached values.
- Dominant language
- Go
- Stars
- 3.6k
- Forks
- 1.6k
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 820
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from erigontech/erigon
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
erigontech/erigon#26523 ·
Maintainers usually reply within 1 day
-
flaky test
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
erigontech/erigon#26230 ·
Maintainers usually reply within 1 day
-
txnprovider/txpool: pending nonce counts past gaps in the poolPossibly taken @yperbasis claimed this 7 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
erigontech/erigon#26014 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
tracing: expose custom error selector and raw payload in callTracer revertReasonPossibly taken @lupin012 claimed this 9 days ago. OpenRPC
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
erigontech/erigon#25928 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
txnprovider/txpool: remove redundant blob/commitment length checkPossibly taken @yperbasis claimed this 14 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
erigontech/erigon#25432 ·
Maintainers usually reply within 1 day
All issues in erigontech/erigon
Similar issues
-
enhancement exporter/awskinesis needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
open-telemetry/opentelemetry-collector-contrib#53334 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 83/100
SocialGouv/iterion#3376 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
seaweedfs/seaweedfs#12740 · 2 comments ·
Maintainers usually reply within 1 day
-
area:indexer bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
seanb4t/codegraph-go#385 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day