notifications: publish finality-only fork-choice updates

Open
#26,378 1 comment 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@yperbasis is already working on this.

Since Nov 18, 2026.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
go

Research direction

Read execution/execmodule/forkchoice.go and the notification contract in #26013, then trace the short-circuit path and publisher behavior for same-head fork-choice updates. Check the subscription reset and publication-sequence logic added in #25515. Done means changed finality metadata reaches existing subscribers and reset reads racing a finality-only commit see the committed marker, without replaying headers or logs or forcing full state recovery; unchanged markers remain a no-op.

Written by the indexing model from the issue text.

Description

A successful same-head fork-choice update that changes only safe/finalized markers commits those markers without publishing a state-change batch. Existing subscribers keep the old finality until a later block; a subscriber whose reset read races that commit can also start with the old marker.

In execution/execmodule/forkchoice.go, the short-circuit path dispatches only when the accumulator has pending changes. With head 4, finalized 1, and an empty accumulator, updating finalized to 3 commits the marker but never calls the publisher. The state version remains unchanged, so the subscription publication-sequence check added in #25515 cannot detect this commit.

The observed consequence is delayed pruning of the txpool's mined-blob cache. Publish changed head metadata independently of execution-state deltas, without replaying headers/logs or forcing full state recovery. Cover an existing subscription and a reset read racing a finality-only commit, including the no-op case where no markers changed. Coordinate the notification contract with #26013.

Dominant language
Go
Stars
3.6k
Forks
1.6k
Avg merge
1d 17h
Merged PRs (30d)
820

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from erigontech/erigon

All issues in erigontech/erigon

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.