db/state/execctx: SharedDomains.Unwind follow-ups from #24304

Open
#26,306 0 comments 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@awskii is already working on this.

Since Nov 14, 2026.

Assessment

This issue has not been assessed yet.

Description

Non-blocking points from the #24304 review, for after it merges:

  • SharedDomains.Unwind on a closed SharedDomains panics: Close sets sdCtx to nil and Unwind dereferences it. No caller unwinds after close today; returning early on a nil sdCtx keeps the old behaviour.
  • With a changeset, Unwind keeps the v3 commitment touches, values included, of keys written only by a dropped block that has no diffset, since unwindExec3 skips such a block. It needs inline touches, so the parallel executor does not reach it. The reviewer has a failing test; not reproduced here yet.
Dominant language
Go
Stars
3.6k
Forks
1.6k
Avg merge
1d 17h
Merged PRs (30d)
820

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from erigontech/erigon

All issues in erigontech/erigon

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.