cl/sentinel/handlers: one 5-request cap across all protocols rejects valid concurrent requests
Maintainers usually reply within 1 day
@domiwei is already working on this.
Since Nov 14, 2026.
Assessment
This issue has not been assessed yet.
Description
Sentinel caps a peer at 5 in-flight req/resp requests across all protocols, while the spec allows up to MAX_CONCURRENT_REQUESTS = 2 open requests per protocol ID, so an honest peer's valid requests can get InvalidRequest.
At main 5b59b99c738:
maxConcurrentRequestsPerPeer = 5incl/sentinel/handlers/rate_limiter.go.wrapStreamHandlerinhandlers.gocallsacquireConcurrencyfor every protocol, so all protocols share the 5 slots.
Failing case:
- During sync a peer runs 2 DataColumnSidecarsByRoot and 2 DataColumnSidecarsByRange requests to one Caplin node, as the spec allows.
- One slot is left, so a concurrent BlocksByRange, BlobsByRoot, Status or Metadata request beyond it gets
InvalidRequestfrom the wrapper. - #26288 keeps large column streams alive up to 40 s instead of about 5 s, so the slots stay taken longer. It lists this as a known risk and does not change it.
Unknown: whether Lighthouse scores or bans a peer for these rejections.
Expected: the cap allows at least MAX_CONCURRENT_REQUESTS per protocol, or the data column protocols do not count against the shared cap.
- Dominant language
- Go
- Stars
- 3.6k
- Forks
- 1.6k
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 820
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from erigontech/erigon
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
erigontech/erigon#26523 ·
Maintainers usually reply within 1 day
-
flaky test
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
erigontech/erigon#26230 ·
Maintainers usually reply within 1 day
-
txnprovider/txpool: pending nonce counts past gaps in the poolPossibly taken @yperbasis claimed this 7 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
erigontech/erigon#26014 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
tracing: expose custom error selector and raw payload in callTracer revertReasonPossibly taken @lupin012 claimed this 9 days ago. OpenRPC
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
erigontech/erigon#25928 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
txnprovider/txpool: remove redundant blob/commitment length checkPossibly taken @yperbasis claimed this 14 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
erigontech/erigon#25432 ·
Maintainers usually reply within 1 day
All issues in erigontech/erigon
Similar issues
-
enhancement exporter/awskinesis needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
open-telemetry/opentelemetry-collector-contrib#53334 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 83/100
SocialGouv/iterion#3376 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
seaweedfs/seaweedfs#12740 · 2 comments ·
Maintainers usually reply within 1 day
-
area:indexer bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
seanb4t/codegraph-go#385 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day