cl/sentinel/handlers: one 5-request cap across all protocols rejects valid concurrent requests

Open
#26,301 0 comments 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@domiwei is already working on this.

Since Nov 14, 2026.

Assessment

This issue has not been assessed yet.

Description

Sentinel caps a peer at 5 in-flight req/resp requests across all protocols, while the spec allows up to MAX_CONCURRENT_REQUESTS = 2 open requests per protocol ID, so an honest peer's valid requests can get InvalidRequest.

At main 5b59b99c738:

  • maxConcurrentRequestsPerPeer = 5 in cl/sentinel/handlers/rate_limiter.go.
  • wrapStreamHandler in handlers.go calls acquireConcurrency for every protocol, so all protocols share the 5 slots.

Failing case:

  • During sync a peer runs 2 DataColumnSidecarsByRoot and 2 DataColumnSidecarsByRange requests to one Caplin node, as the spec allows.
  • One slot is left, so a concurrent BlocksByRange, BlobsByRoot, Status or Metadata request beyond it gets InvalidRequest from the wrapper.
  • #26288 keeps large column streams alive up to 40 s instead of about 5 s, so the slots stay taken longer. It lists this as a known risk and does not change it.

Unknown: whether Lighthouse scores or bans a peer for these rejections.

Expected: the cap allows at least MAX_CONCURRENT_REQUESTS per protocol, or the data column protocols do not count against the shared cap.

Dominant language
Go
Stars
3.6k
Forks
1.6k
Avg merge
1d 17h
Merged PRs (30d)
820

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from erigontech/erigon

All issues in erigontech/erigon

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.