Api test: SmtpMailer times out under load
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- testing
Research direction
Start with apps/api/src/adapters/smtp/SmtpMailer.test.ts and trace how each test starts and finishes its send, and when it clears Mailpit. Set a suite timeout above the mailer's roughly eight-second limits and make each test await its in-flight send before cleanup. Verify the API test command passes ten consecutive runs under load, then run pnpm gate.
Written by the indexing model from the issue text.
Description
Found in the review of #828. apps/api/src/adapters/smtp/SmtpMailer.test.ts timed out in two local gate runs; CI stayed green (2.3 s).
Context
The test uses real SMTP on wall-clock time under Vitest's default 5 s limit, while the mailer's own timeouts add up to about 8 s. A send that outlives its test can land after the next test's Mailpit DELETE. This reading comes from the code; it was not reproduced.
Done when
- The suite sets an explicit timeout above the mailer's own limits.
- Each test waits for its in-flight send before the next test clears Mailpit, observing the transition rather than sampling.
-
pnpm --filter @mygame/api testpasses ten runs in a row under load. -
pnpm gategreen.
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 0
- Avg merge
- 30m
- Merged PRs (30d)
- 219
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from emm3000/myGame
-
ready-for-human
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
ready-for-human
Difficulty 4/5 3-5 days Newbie friendliness 48/100
Maintainers usually reply within 1 day
-
ready-for-agent
Difficulty 4/5 3-5 days Newbie friendliness 39/100
Maintainers usually reply within 1 day
-
ready-for-agent
Difficulty 4/5 3-5 days Newbie friendliness 54/100
Maintainers usually reply within 1 day
Similar issues
-
Add "append" and "prepend" slots for vue-vuetify extended renderersPossibly taken @simeyc claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
eclipsesource/jsonforms#2668 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
README の通知条件を実際の判定処理に合わせるPossibly taken @unhappychoice claimed this today. Openfactory:in-progress priority:medium
Difficulty 1/5 Under an hour Newbie friendliness 90/100
unhappychoice/oss-issue-opener#395 · 1 comment ·
Maintainers usually reply within 1 day
-
bug Website
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
OWASP/OWASP-Hunting#88 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day