okl warm stop reports no server when one answered slower than the prompt's 0.5 s budget
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 85/100
Research direction
Start in src/okl/warm.py at lines 464-473 where warm.stop() uses the 0.5s TIMEOUT_S. Give stop and ping (for okl warm status) a longer timeout of a few seconds, keeping TIMEOUT_S for the prompt embed. Add a test in tests/test_warm.py that delays the server past TIMEOUT_S and asserts stop() is True; confirm it fails before the fix. Done when okl warm stop reports the server it actually stopped.
Written by the indexing model from the issue text.
Description
The defect. warm.stop() sends the stop request with TIMEOUT_S (0.5 s), the budget a prompt allows for its vector. A server that takes longer than that to answer still receives the request and exits, but the client times out first, so stop() returns False. okl warm stop then reports that no server answered, even though it stopped one. src/okl/warm.py:464-473.
Seen. On #312's CI, 2026-10-31, tests/test_warm.py::test_the_server_answers_ping_embed_and_stop failed on Python 3.11 only, at assert warm.stop() is True, with the other Pythons green on the same commit. #312 does not touch warm.py. A busy runner is enough to push the server's answer past 0.5 s.
Fix. Give stop (and ping when a person runs okl warm status) a timeout of its own, a few seconds, since nothing waits on it the way a prompt does. Keep TIMEOUT_S for the prompt's embed. Add a test that slows the server's answer past TIMEOUT_S and still expects stop() to be True, and check that it fails before the fix.
- Dominant language
- Python
- Stars
- 1
- Forks
- 1
- Avg merge
- 7h 42m
- Merged PRs (30d)
- 110
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from emeraldleaf/okl
-
enhancement loop-review
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
emeraldleaf/okl#190 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
emeraldleaf/okl#147 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 70/100
emeraldleaf/okl#319 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 50/100
emeraldleaf/okl#318 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
emeraldleaf/okl#317 · 1 comment ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 80/100
Imbad0202/academic-research-skills#1039 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
alexgreensh/token-optimizer#297 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
superdesigndev/treg#1343 ·
Maintainers usually reply within 1 day
-
GitHub handle should allow underscoresPossibly taken @PrakarshSrivastav claimed this today. Openbug good-first-issue
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
nf-core/tools#4581 · 1 comment ·
Maintainers usually reply within 1 day
-
good first issue test
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
ANCORATE/EncryptHome#8 ·