okl reverify re-stamps a doc or comment edit that its check doesn't test
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
Research direction
Start from the okl reverify command and the code path that stamps a lesson when its stored check passes, including how --yes skips confirmation. The payload names no files, so locate them first. Done means that a drifted lesson with a changed doc file shows the diff since the verified commit and asks before stamping, even with --yes, unless a flag says the diff was read. Decide the comment-only edit case with a maintainer before coding.
Written by the indexing model from the issue text.
Description
okl reverify stamps whenever the stored check passes, and it never shows what changed. In the trial, two edits got fresh stamps because the check tested neither:
- an ADR edit that renamed every error code;
- a code comment that had been made false.
So a lesson that governs a doc reads as proven after its doc changed meaning.
Proposal: when a drifted lesson's changed files include a doc (.md, .rst, .adoc, .txt), okl reverify prints the diff since the verified commit and asks before stamping, even with --yes, unless a flag says the diff was read. Consider the same for comment-only edits.
Found by the #207 audit (a docs audit, a code audit, a newcomer read and an end-to-end trial on okl 0.8.7, each finding adversarially verified). Part of #207.
- Dominant language
- Python
- Stars
- 1
- Forks
- 1
- Avg merge
- 5h 22m
- Merged PRs (30d)
- 119
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from emeraldleaf/okl
-
enhancement loop-review
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
emeraldleaf/okl#190 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
emeraldleaf/okl#147 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 36/100
emeraldleaf/okl#365 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 35/100
emeraldleaf/okl#357 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
emeraldleaf/okl#349 ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
huggingface/deep-rl-class#723 ·
-
[tool] bug: Qwen3 XML tool parser raises on `...` argument values (Ellipsis is not JSON serializable)Possibly taken @super-yuki claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 87/100
verl-project/verl#8559 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
TencentCloud/octop-harness#228 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
google/osv-scalibr#2585 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
NousResearch/hermes-agent#149323 ·
Maintainers usually reply within 1 day