Rename dynamic to ???

Open
#4,698 2 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
elixir
Domain
databases

Research direction

Start by reviewing the dynamic/1 macro defined in Ecto.Query and the naming alternatives listed in the issue. The work is done when a replacement name is agreed that avoids confusion with Elixir's type system and possible Kernel conflicts.

Written by the indexing model from the issue text.

Description

Kind:Bug
Elixir version

Future Elixir versions

Database and Version

All

Ecto Versions

All

Database Adapter and Versions (postgrex, myxql, etc)

All

Current behavior

Currently we define a dynamic/1 macro but:

  1. Elixir's type system also has a dynamic/1 and they will be confusing
  2. Elixir's kernel may also get a dynamic/1 function, which may cause conflicts
Expected behavior

Rename it to something else. The question is what:

  1. dynamic_query is redundant as it is defined in Ecto.Query
  2. dynamic_fragment feels incompatible as fragments are strings
  3. dynamic_expr feels too technical? It can be because I am not a native speaker

Thoughts @greg-rychlewski?

Dominant language
Elixir
Stars
6.5k
Forks
1.5k
Avg merge
8h 38m
Merged PRs (30d)
8

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from elixir-ecto/ecto

All issues in elixir-ecto/ecto

Similar issues

More Elixir issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.