Rename dynamic to ???
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Start by reviewing the dynamic/1 macro defined in Ecto.Query and the naming alternatives listed in the issue. The work is done when a replacement name is agreed that avoids confusion with Elixir's type system and possible Kernel conflicts.
Written by the indexing model from the issue text.
Description
Elixir version
Future Elixir versions
Database and Version
All
Ecto Versions
All
Database Adapter and Versions (postgrex, myxql, etc)
All
Current behavior
Currently we define a dynamic/1 macro but:
- Elixir's type system also has a
dynamic/1and they will be confusing - Elixir's kernel may also get a
dynamic/1function, which may cause conflicts
Expected behavior
Rename it to something else. The question is what:
dynamic_queryis redundant as it is defined in Ecto.Querydynamic_fragmentfeels incompatible as fragments are stringsdynamic_exprfeels too technical? It can be because I am not a native speaker
Thoughts @greg-rychlewski?
- Dominant language
- Elixir
- Stars
- 6.5k
- Forks
- 1.5k
- Avg merge
- 8h 38m
- Merged PRs (30d)
- 8
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from elixir-ecto/ecto
-
Kind:Enhancement
Difficulty 4/5 3-5 days Newbie friendliness 42/100
elixir-ecto/ecto#4271 · 17 comments · 2 reactions ·
Maintainers usually reply within 1 day
All issues in elixir-ecto/ecto
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
intellij-elixir/intellij-elixir#4782 ·
Maintainers usually reply within 1 day
-
level 2 wocs
Difficulty 1/5 Under an hour Newbie friendliness 90/100
phravins/QuantumBilling#51 ·
-
fix(ocr): compile the Tesseract-free pipeline with Tokio runtimePossibly taken @Goldziher claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
carverauto/serviceradar#6898 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
elixir-ecto/myxql#221 ·