Supporting standard `---` convention for comments to not be included in public APIs
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 38/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- go, kubernetes
- Domain
- documentation
Research direction
Start by reviewing the linked controller-tools PR and then trace how this tool currently processes comments for public CRD API documentation. Define the expected behavior for comments prefixed with ---, including retaining ordinary comments, and add tests showing that the prefixed comments are excluded.
Written by the indexing model from the issue text.
Description
We recently had a PR https://github.com/elastic/cloud-on-k8s/pull/8020 where we wanted to include a comment in a public CRD, but didn't want it to be included in the public-facing API docs. It seems that the controller-tools supports using --- to preface comments to not be included. I think this tooling may want to support this as well to be consistent.
- Dominant language
- Go
- Stars
- 176
- Forks
- 81
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from elastic/crd-ref-docs
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
elastic/crd-ref-docs#204 ·
-
Support for +kubebuilder:validation:Required and omitemptyPossibly taken @swathinsankaran claimed this 117 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
elastic/crd-ref-docs#198 · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
elastic/crd-ref-docs#191 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
elastic/crd-ref-docs#188 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
elastic/crd-ref-docs#182 ·
All issues in elastic/crd-ref-docs
Similar issues
-
bug
Difficulty 2/5 Half a day Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
kind/bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
kubernetes-sigs/external-dns#6816 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
ANSI translator ignores SGR 22/24 (and other attribute-off codes): bold and underline never turn offOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Named Tuple element with a space in its name fails to parsePossibly taken @spicysharkco claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ClickHouse/clickhouse-go#2073 ·
Maintainers usually reply within 1 day