Allow for full url specification
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 52/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- api
Research direction
Start at src/client.js around line 50, where the endpoint is assembled, and review how the App Search client is configured. Check how search-ui or an API gateway would need to provide a custom endpoint. Done means the SDK consumer can specify the full endpoint without custom middleware or fixed string concatenation.
Written by the indexing model from the issue text.
Description
There are cases in which app search is being an API gateway or reverse proxy that benefits from allowing the consumer of the app-search client to specify what the end point should be.
This recently came up on a search-ui implementation where just the production environment was going to be behind a API gateway. This would require implementing a custom handler/middleware in search-ui which would be better to simply have the string concatenation for the endpoint overwritten or specified by the consumer of the SDK.
https://github.com/elastic/app-search-javascript/blob/master/src/client.js#L50
- Dominant language
- JavaScript
- Stars
- 67
- Forks
- 18
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from elastic/app-search-javascript
-
Sort usingOpen
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
CORS on httpsOpen
Difficulty 4/5 3-5 days Newbie friendliness 20/100
elastic/app-search-javascript#28 · 2 comments ·
-
Typescript supportOpen
Difficulty 5/5 Over a week Newbie friendliness 25/100
elastic/app-search-javascript#27 · 10 comments · 13 reactions ·
All issues in elastic/app-search-javascript
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
smansfield635-create/smansfield635-create.github.io#5818 · 4 comments ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
danjdewhurst/story-skills#538 ·
Maintainers usually reply within 1 day
-
good first issue
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
anoopcodehack/DevBoard#589 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 Under an hour Newbie friendliness 85/100
capricorn86/happy-dom#2474 ·
Maintainers usually reply within 2 days
-
Difficulty 1/5 Under an hour Newbie friendliness 95/100
vigetlabs/mega-menu-block#30 ·
Maintainers usually reply within 2 days