README config example breaks when copied into ~/.nodeenvrc
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 90/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- python
- Domain
- documentation
Research direction
Open the Configuration section of README.rst and compare it with the output of nodeenv --dump-config-defaults. Check how Config._load handles the documented values, then update the example so copied options match the command output and mirror is omitted or commented out. Done means the README example no longer introduces quoted values or an unusable mirror setting.
Written by the indexing model from the issue text.
Description
The Configuration section of README.rst lists the options with Python-style values:
[nodeenv]
node = 'latest'
npm = 'latest'
with_npm = False
jobs = '2'
...
make = 'make'
...
mirror = None
Config._load reads the file with ConfigParser.get, which returns the raw string, so the quotes become part of the value. Copied into ~/.nodeenvrc, five of the fifteen lines change the option:
| Line in README | Value nodeenv gets |
|---|---|
node = 'latest' |
"'latest'" |
npm = 'latest' |
"'latest'" |
jobs = '2' |
"'2'" |
make = 'make' |
"'make'" |
mirror = None |
'None' |
The boolean lines are fine, because getboolean accepts True and False.
Reproduce
On master (e745358):
$ printf "[nodeenv]\nnode = 'latest'\n" > quoted.ini
$ nodeenv -C quoted.ini env
...
ValueError: invalid literal for int() with base 10: "'latest'"
$ printf "[nodeenv]\nmirror = None\n" > mirror.ini
$ nodeenv -C mirror.ini --node=22.11.0 env
* Install prebuilt node (22.11.0) .Error: cannot download https://None/download/release/v22.11.0/node-v22.11.0-darwin-arm64.tar.gz: [Errno 8] nodename nor servname provided, or not known
Where it comes from
The block was added in ac9a510 ("Add ability to configure mirror through setting file"). nodeenv --dump-config-defaults, whose docstring says it prints the defaults for the README, now prints the values without quotes, but it still prints mirror = None.
Possible fix
Regenerate the block from --dump-config-defaults, and leave mirror out of it or show it commented out, since it has no default.
- Dominant language
- Python
- Stars
- 1.8k
- Forks
- 224
- Avg merge
- 10h 15m
- Merged PRs (30d)
- 22
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ekalinin/nodeenv
-
docs
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
ekalinin/nodeenv#416 · 3 comments ·
Maintainers usually reply within 1 day
All issues in ekalinin/nodeenv
Similar issues
-
ACK_WAITING HELP_WANTED UPDATE_CS
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
OWASP/CheatSheetSeries#2458 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
BasedHardware/omi#19711 ·
Maintainers usually reply within 1 day
-
Qwen3_5MoeModel no longer returns router_logits, breaking aux loss with output_router_logits=TrueOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
huggingface/transformers#49172 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
vllm-project/vllm-metal#885 ·
Maintainers usually reply within 1 day