mail: declare DIRIGIBLE_MAIL_SENDER and make the sender / reply-to tenant-overridable
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- java
- Domain
- authentication, backend
Research direction
Start by reading DirigibleConfig and TenantConfigurationKeyPolicy, then trace how generated notify: code resolves DIRIGIBLE_MAIL_SENDER before calling Mail.send(...). Define the sender and reply-to tenant behavior and check existing tenant-configuration tests; done means the effective tenant values are used, with documentation identifying which mail keys are per tenant. The optional per-tenant SMTP credentials need separate scope.
Written by the indexing model from the issue text.
Description
Problem
Mail is configured once per instance. Generated notify: code calls Configurations.get("DIRIGIBLE_MAIL_SENDER", "[email protected]") and then Mail.send(...), and SMTP comes from the deployment-wide DIRIGIBLE_MAIL_* keys.
None of these keys is tenant-overridable: TenantConfigurationKeyPolicy allows only its listed keys plus the DIRIGIBLE_PRINT_TEMPLATE_ prefix. DIRIGIBLE_MAIL_SENDER is not a declared DirigibleConfig key at all.
In a multitenant application every tenant's invoices, dunning letters and payslips are therefore sent from the same address, and replies go to the operator rather than to the tenant's company.
Proposal
- Declare
DIRIGIBLE_MAIL_SENDERinDirigibleConfig, and make it tenant-overridable together with a newDIRIGIBLE_MAIL_REPLY_TO(the cheap, safe part: one SMTP account, a per-tenant From display name or Reply-To). - Optionally: per-tenant SMTP credentials, stored as tenant configuration secrets, falling back to the instance's account.
- Generated
notify:code reads the effective, tenant-resolved value. - Docs: which mail keys are per tenant.
- Dominant language
- Java
- Stars
- 278
- Forks
- 97
- Avg merge
- 19h 30m
- Merged PRs (30d)
- 242
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from eclipse-dirigible/dirigible
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
eclipse-dirigible/dirigible#7958 ·
Maintainers usually reply within 1 day
-
intent: a create-from without fromStatus answers 200 on a missing or unknown source id (no 400/404)Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
eclipse-dirigible/dirigible#7945 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
eclipse-dirigible/dirigible#7891 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
eclipse-dirigible/dirigible#6538 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
eclipse-dirigible/dirigible#4812 ·
Maintainers usually reply within 1 day
All issues in eclipse-dirigible/dirigible
Similar issues
-
area: android good first issue help wanted testing
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Gautam-aman/ResQNet#56 ·
Maintainers usually reply within 1 day
-
documentation hermes-queue
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
chrisalunlloyd2-sudo/mindpalace#294 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
QuicksilverMC/Argentum#31 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
saysky/ForestBlog#111 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
eclipse-hawkbit/hawkbit#3429 · 1 comment ·
Maintainers usually reply within 1 day