Issue with nested reitit routes in upcoming version
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Reproduce the issue from the nested :routes example in duct.edn using the listed org.duct-framework/main and module.web versions, then inspect the reitit.core router output and the response path for /v1/pong. Done means both nested routes work and the request no longer produces the 404 or the StreamableResponseBody exception.
Written by the indexing model from the issue text.
Description
In the upcoming version there seems to be an issue with nested reitit routes.
Flat routes work
:routes
[["/ping" :my-test/ping]
["/pong" :my-test/pong]]
But when specified in nested form
:routes
[["/v1"
["/ping" :my-test/ping]
["/pong" :my-test/pong]]]
only the first route works. The /v1/pong route results in a 404.
I checkd with
(require '[reitit.core :as r])
(-> "duct.edn"
slurp
(str/replace "#ig/ref" "")
read-string
:system
:duct.module/web
:routes
r/router
r/routes)
and the result seems fine.
Addendum:
Well at least the error message leads to the conclusion that it wants to respond with a 404. What I actually get is Error 500 java.lang.IllegalArgumentException: No implementation of method: :write-body-to-stream of protocol: #'ring.core.protocols/StreamableResponseBody found for class: clojure.lang.PersistentArrayMap and then SERVLET:</th><td>org.eclipse.jetty.servlet.ServletHandler$Default404Servlet.
This is with
org.duct-framework/main {:mvn/version "0.1.8"}
org.duct-framework/module.web {:mvn/version "0.12.7"}
- Dominant language
- Clojure
- Stars
- 22
- Forks
- 22
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from duct-framework/module.web
-
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
duct-framework/module.web#21 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
duct-framework/module.web#8 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
duct-framework/module.web#7 · 4 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
duct-framework/module.web#4 · 1 comment ·
All issues in duct-framework/module.web
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
.Needs Triage .Team/UXWest Priority:P3 Type:Bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
metabase/metabase#83410 · 1 comment ·
Maintainers usually reply within 1 day
-
contribution welcome good first issue WG adoption
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 91/100
NoahTheDuke/splint#52 · 1 comment ·
-
Setup dependabotOpen
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
software-mansion/starknet-jvm#631 ·