Build fails on FreeBSD: error: redefinition of 'addrinfo'
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start with extension/postgres_scanner/postgres/src/include/getaddrinfo.h and pqcomm.h, then compare their definitions with FreeBSD's /usr/include/netdb.h and sys/_sockaddr_storage.h. Reproduce the build on FreeBSD and update the platform handling so the bundled sources no longer redefine these structures; done means the build completes without both errors.
Written by the indexing model from the issue text.
Description
What happens?
In file included from /usr/ports/databases/duckdb/work/duckdb-1.4.4/extension/postgres_scanner/postgres/src/common/ip.c:37:
In file included from /usr/ports/databases/duckdb/work/duckdb-1.4.4/extension/postgres_scanner/postgres/src/include/common/ip.h:17:
/usr/ports/databases/duckdb/work/duckdb-1.4.4/extension/postgres_scanner/postgres/src/include/getaddrinfo.h:98:8: error: redefinition of 'addrinfo'
98 | struct addrinfo
| ^
/usr/include/netdb.h:133:8: note: previous definition is here
133 | struct addrinfo {
| ^
In file included from /usr/ports/databases/duckdb/work/duckdb-1.4.4/extension/postgres_scanner/postgres/src/common/ip.c:37:
In file included from /usr/ports/databases/duckdb/work/duckdb-1.4.4/extension/postgres_scanner/postgres/src/include/common/ip.h:18:
/usr/ports/databases/duckdb/work/duckdb-1.4.4/extension/postgres_scanner/postgres/src/include/libpq/pqcomm.h:44:8: error: redefinition of 'sockaddr_storage'
44 | struct sockaddr_storage
| ^
/usr/include/sys/_sockaddr_storage.h:45:8: note: previous definition is here
45 | struct sockaddr_storage {
| ^
2 errors generated.
These structures are re-defined in the downloaded code tarball and structures are different.
To Reproduce
Build on FreeBSD.
OS:
FreeBSD 15 STABLE
PostgreSQL Version:
N/A
DuckDB Version:
1.4.4
DuckDB Client:
1.4.4
Full Name:
Yuri Vic
Affiliation:
FreeBSD
Have you tried this on the latest main branch?
- I agree
Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?
- I agree
- Dominant language
- C++
- Stars
- 375
- Forks
- 113
- Avg merge
- 6h 42m
- Merged PRs (30d)
- 30
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from duckdb/duckdb-postgres
-
Difficulty 3/5 1-2 days Newbie friendliness 62/100
duckdb/duckdb-postgres#623 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 62/100
duckdb/duckdb-postgres#618 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
duckdb/duckdb-postgres#594 · 4 comments ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
duckdb/duckdb-postgres#575 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 74/100
duckdb/duckdb-postgres#564 · 1 comment ·
Maintainers usually reply within 1 day
All issues in duckdb/duckdb-postgres
Similar issues
-
Jupyter kernel leaks two file descriptors per cell; after ~100 cells every cell fails with "pipe() failed"Possibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Test discovery aborts on GPU builds without cuStateVec: check_cuStateVec expects a failed result but set_config() now raises RuntimeErrorPossibly taken @dmeliksetian claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Qiskit/qiskit-aer#2495 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
sumatrapdfreader/sumatrapdf#6403 ·
-
Module:Polygraphy
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
enhancement GUI maintainer-review
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
aethersdr/AetherSDR#6681 · 1 comment ·
Maintainers usually reply within 1 day