Consider allowing a licence arg/option to gen_build_npm so output can live in third_party

Open
#18 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
38/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
node.js, python
Domain
build-system

Research direction

Locate the gen_build_npm entry point and inspect how it creates BUILD and shrikwrap files. Check how existing options are parsed, then define completion as accepting a licence option and including that licence in generated files so they can be placed under a Bazel project's third_party directory.

Written by the indexing model from the issue text.

Description

I'm not that experienced with bazel but I feel like it would be fitting for the generated BUILD/shrikwrap files to exist in the third_party dir of a bazel project.

Unfortunately all BUILD files under third_party require a licence and there's no way to get gen_build_npm to include one in the created BUILD files.

Dominant language
Python
Stars
53
Forks
11
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dropbox/rules_node

All issues in dropbox/rules_node

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.