[propose] Should we have event caller (f_back) in type_comments?
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Start with pyannotate_runtime/collect_types.py at lines 446-448, then inspect the related FunctionKey changes mentioned in the issue. Compare the current type_comments structure with the proposed caller-to-type mapping and determine whether the added caller context is consistent and acceptable for the collected samples. Done means the proposal has a decided design and an identified implementation scope.
Written by the indexing model from the issue text.
Description
If you have multiple functions calling one function, it will look like this.
{
"path": "~~~",
"line": 1,
"func_name": "called_func",
"type_comments": [
"(int) -> int"
"(int) -> str"
],
"samples": 2
},
I would like to know which function calls the called_func in this case.
{
"path": "~~~",
"line": 1,
"func_name": "called_func",
"type_comments": [
{
"calling1_func": "(int) -> int",
}
{
"calling2_func": "(int) -> str",
}
],
"samples": 2
},
... because there are chances to have 10 or more samples (sadly).
remarks
This must change the code below (and more. such as FunctionKey), but it maybe gets slower.
So I want to know if this proposal is ideal or not. If ideal I think I can contribute when I have a time (maybe late of this month)
- Dominant language
- Python
- Stars
- 1.4k
- Forks
- 59
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dropbox/pyannotate
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
dropbox/pyannotate#124 · 3 reactions ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
dropbox/pyannotate#123 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
dropbox/pyannotate#109 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
dropbox/pyannotate#103 · 6 comments · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
dropbox/pyannotate#102 ·
All issues in dropbox/pyannotate
Similar issues
-
good first issue hacktoberfest
Difficulty 1/5 Under an hour Newbie friendliness 92/100
RogueAlg0/taken#387 · 4 comments ·
Maintainers usually reply within 1 day
-
tool-calling
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
vllm-project/vllm#59838 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
raullenchai/Rapid-MLX#4042 ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 92/100
transitmatters/mbta-slow-zone-bot#70 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
open-webui/open-webui#31871 · 1 comment ·
Maintainers usually reply within 1 day