jit-diff handling of errors (e.g., JIT asserts) should be improved

Open
#94 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
cli, tooling

Research direction

Reproduce the reported jit-diff command and inspect the error-handling path behind “Dasm commands returned with total of 2 failures.” Trace where the generated *.err files and diff compiler results are handled. Done means the output identifies the relevant .err paths and processing continues to produce available diffs after JIT asserts.

Written by the indexing model from the issue text.

Description

I ran diffs with:

jit-diff diff -o c:\diffs -t 4 -a -f -v --test_root c:\gh\coreclr\bin\tests\Windows_NT.x86.Release --core_root c:\gh\coreclr\bin\tests\Windows_NT.x86.checked\Tests\Core_Root -b e:\gh\coreclr2\bin\Product\Windows_NT.x86.checked -d c:\gh\coreclr\bin\Product\Windows_NT.x86.checked

It ran all baselines (as far as I know), but two failed with asserts. It then output:

Dasm commands returned with total of 2 failures

and stopped.

This message is not useful. It should print out the file paths of the *.err files that were generated, capturing the errors.

It should also continue, running the diff compiler as well, so I get as many diffs as possible.

Dominant language
C#
Stars
161
Forks
69
Avg merge
1h 56m
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/jitutils

All issues in dotnet/jitutils

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.