Update clang-tidy and clang-format to newer versions and upload binaries for macOS arm64

Open
#352 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
macos, shell
Domain
build-system, tooling

Research direction

Start with bootstrap.sh and inspect how it downloads clang-format and clang-tidy, then compare the referenced LLVM 13.0.1 release assets. Done means bootstrap.sh succeeds on macOS arm64 with available binaries, either by updating the downloads or adding a pipeline similar to coredistools.

Written by the indexing model from the issue text.

Description

Right now running bootstrap.sh on macOS arm64 will fail with the following output:

Downloading clang-format to bin directory
curl: (22) The requested URL returned error: 404                                                                                                                                                         

chmod: bin/clang-format: No such file or directory
Downloading clang-tidy to bin directory
curl: (22) The requested URL returned error: 404                                                                                                                                                         

chmod: bin/clang-tidy: No such file or directory
Either clang-tidy or clang-format was not installed. Please install and put them on the PATH to use jit-format.
Tools can be found at http://llvm.org/releases/download.html#3.8.0
ERROR: Failed to download clang-format and clang-tidy

The easiest way to fix the issue would be to upload clang-tidy and clang-format from the official LLVM releases.
However, https://github.com/llvm/llvm-project/releases/tag/llvmorg-13.0.1 doesn't contain any native tools for macOS arm64.

As a workaround, another pipeline (similar to coredistools) can be added to the repo that will produce clang-tidy and clang-format binaries on demand.

cc @BruceForstall

Dominant language
C#
Stars
161
Forks
69
Avg merge
1h 56m
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/jitutils

All issues in dotnet/jitutils

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.