jit-diff (and maybe more) broken by recent runtime build change from windows_nt to windows

Open
#299 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
csharp
Domain
devtools, tooling

Research direction

Start in src/jit-diff/jit-diff.cs at GetBuildOS and trace how its Windows_NT or Windows result is consumed. Determine the backwards-compatibility requirement for the recent runtime build naming change, then verify that jit-diff and any affected behavior work with the supported build names.

Written by the indexing model from the issue text.

Description

Not sure yet how we fix this in a backwards compatible fashion.

index b44e826..a95e5ce 100755
--- a/src/jit-diff/jit-diff.cs
+++ b/src/jit-diff/jit-diff.cs
@@ -94,7 +94,7 @@ private static string GetBuildOS(string platformMoniker)
             switch (platformMoniker)
             {
                 case "Windows":
-                    return "Windows_NT";
+                    return "Windows";
                 case "Linux":
                     return "Linux";
                 case "OSX":

cc @dotnet/jit-contrib

Dominant language
C#
Stars
161
Forks
69
Avg merge
1h 56m
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/jitutils

All issues in dotnet/jitutils

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.