Proposal: incorporate superpmicollect functionality into jitutils

Open
#231 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
csharp, python
Domain
tooling

Research direction

Start by reading src/coreclr/tests/src/JIT/superpmi/superpicollect.cs and comparing its collection workflow with src/coreclr/scripts/superpmi.py. Then inspect the existing jitutils tool suite to determine where this functionality could fit. Done means an agreed design and an integrated tool for creating SuperPMI collections without leaving the JIT tool suite.

Written by the indexing model from the issue text.

Description

The "superpmicollect" tool is both a coreclr unit test for testing SuperPMI, and a generalized SuperPMI collection harness.

Consider incorporating the superpmicollect functionality into jitutils and using it for creating a tool to easily create SuperPMI collections.

Current superpmicollect source: https://github.com/dotnet/runtime/blob/master/src/coreclr/tests/src/JIT/superpmi/superpmicollect.cs

This would somewhat duplicate the functionality in the superpmi.py script (https://github.com/dotnet/runtime/blob/master/src/coreclr/scripts/superpmi.py). However, they might be advantages in simplicity to adding it to the same suite of tools already used by the JIT, implemented in C#.

Dominant language
C#
Stars
161
Forks
69
Avg merge
1h 56m
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/jitutils

All issues in dotnet/jitutils

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.