[Suggestion]: idle live roots wake every 25 ms; notify-debouncer-full fixed this on main (notify #933)
Maintainers usually reply within 3 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- rust
- Domain
- performance
Research direction
Start with crates/fff-core/src/watcher/background_watcher.rs at the debounce timeout setup, then inspect the vendored fff-notify-debouncer-full loop described in the issue. Compare notify-rs PR #933 with the current fork and decide whether to port only that change or track upstream main; the thread asks maintainers to agree on the approach. Done means idle roots stop polling while debounce timing stays unchanged, with a test counting idle loop iterations.
Written by the indexing model from the issue text.
Description
I am a user of fff-search. I measured idle watcher cost on macOS with fff-search 0.11.0 (mode: Ai, watch: true, off-screen probe): each idle live root uses about 0.45 ms CPU/s and about 33 interrupt wakeups/s; three roots about 100 wakeups/s; no root 0.
The cause is the debouncer thread: fff-notify-debouncer-full 0.9.4 runs loop { thread::sleep(tick); debounced_events() } (src/lib.rs:765 of that crate), with tick = DEBOUNCE_TIMEOUT / 2 = 25 ms (crates/fff-core/src/watcher/background_watcher.rs:195-197). It never waits for events, so an idle root wakes about 40 times a second.
Upstream already has the fix: notify-rs PR #933 (merged 2026-06-01, https://github.com/notify-rs/notify/pull/933) adds a Condvar so the loop sleeps until events are queued, then keeps the same tick until they expire. Debounce timing is unchanged. It is not in a crates.io release yet, and fff-notify-debouncer-full 0.9.4 predates it.
Proposal: bring that change into fff-notify-debouncer-full, with a test that counts idle loop iterations. No public API change. I can open the PR only after you agree on the approach. Should the fork track notify-debouncer-full main, or take only #933?
- Dominant language
- Rust
- Stars
- 11.2k
- Forks
- 473
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 32
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dmtrKovalenko/fff
-
triaged
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
dmtrKovalenko/fff#842 · 2 comments ·
Maintainers usually reply within 3 days
-
[Bug]: on a non-git base path, the watcher indexes new files in hidden folders that the scan skips (0.11.0)Possibly taken @gustav-fff claimed this 2 days ago. Opentriaged
Difficulty 3/5 1-2 days Newbie friendliness 35/100
dmtrKovalenko/fff#972 · 1 comment ·
Maintainers usually reply within 3 days
-
[Bug]: nvim: cursor moves left when prompt_vim_mode = true and when the picker is closed with <C-c>Possibly taken @gustav-fff claimed this 3 days ago. Openbug triaged
Difficulty 3/5 1-2 days Newbie friendliness 35/100
dmtrKovalenko/fff#968 · 2 comments ·
Maintainers usually reply within 3 days
-
[Bug]: FFF MCP process diagnosticsPossibly taken @gustav-fff claimed this 6 days ago. Openbug triaged
Difficulty 1/5 Under an hour Newbie friendliness 15/100
dmtrKovalenko/fff#955 · 1 comment ·
Maintainers usually reply within 3 days
-
triaged
Difficulty 4/5 3-5 days Newbie friendliness 22/100
dmtrKovalenko/fff#942 · 4 comments ·
Maintainers usually reply within 3 days
All issues in dmtrKovalenko/fff
Similar issues
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
mozilla-services/syncstorage-rs#2715 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 82/100
physicsdolphin/nv-uefi-unlocker#53 · 4 reactions ·
Maintainers usually reply within 1 day