Need for indicating alignment/padding?
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 30/100
Research direction
Start with issue #190 and clarify the compelling alignment or padding use case, since no files or tests are identified. Compare the proposed four-bit power-of-two alignment flag, an additional padded-allocation bit, and extending the struct; done means an agreed design with its allocation and large-load semantics documented.
Written by the indexing model from the issue text.
Description
Right now I am not sure there is a large need for this, as in most cases importers can discover the data alignment itself quickly from the pointer and e.g. CUDA base allocations are padded to 256 bytes.
But it came up once more as a question whether we could indicate alignment and ISTR at least some discussion around it a long time ago. So if there is a compelling use-case it would seem reasonable to me to add this.
One way I think this could be done cheaply, is to:
- Use 4 bits (
uint4) of the flag space to store a power of two alignment (alignment = 2**uint4_val). - Either assuming a padded allocation or using an additional bit to indicate that the allocation is padded to allow large loads (writes?).
(Of course one could also extend the struct, this just seems like a smaller decision to use a bit of flag space even if not quite unlimited.)
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 168
- Avg merge
- 1m
- Merged PRs (30d)
- 2
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dmlc/dlpack
-
SpecificationOpen
Difficulty 2/5 1-3 hours Newbie friendliness 57/100
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
charmplusplus/charm#4210 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
[BUG] VPN auth dialog spawned by the secret agent fails with "TLS support is not available" on NixOSOpenbug nixos umbriel
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
noctalia-dev/noctalia#5310 ·
Maintainers usually reply within 1 day
-
area/docdb kind/bug priority/medium status/awaiting-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
yugabyte/yugabyte-db#37426 ·
Maintainers usually reply within 1 day
-
[Engine] Two prompt block scorers enabled at once: WMMA silently wins and no log line is printedOpen
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Niko1221/Strata#5693 · 2 comments ·
Maintainers usually reply within 4 days