Gradle does not detect java sources for `java-gradle-plugin`
@nedtwigg is already working on this.
Since Jan 26, 2023.
Assessment
This issue has not been assessed yet.
Description
With gradle 4.1 and spotless 3.6.0, the following worked. With gradle 5.6 and spotless 3.24.1, it silently fails to format sources.
apply plugin: 'java-gradle-plugin'
spotless {
java { ... }
}
This is similar to #111 (spotless fails to detect android sources). Just like #111, the workaround is to list the target explicitly: target 'src/main/java/**/*.java', 'src/test/java/**/*.java'.
Silently not formatting is a bummer. Would perhaps be good for Spotless to report a warning if a format has been described, but the target turned out to be empty.
Project which reproduces this issue:
- works before this commit, broken after it: https://github.com/diffplug/image-grinder/pull/2/commits/3e73517746e1a1bf899a8b593c21cf71c2a72c8e
- workaround: https://github.com/diffplug/image-grinder/pull/2/commits/8b69781c6ee90a59c6546eaa99ba5065ace38aff
- Dominant language
- Java
- Stars
- 5.7k
- Forks
- 560
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 43
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from diffplug/spotless
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 66/100
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
All issues in diffplug/spotless
Similar issues
-
bug untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
opensearch-project/ml-commons#5094 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
emitter:client:csharp feature
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
affects/8.10 affects/8.9 component/clients kind/bug likelihood/mid severity/mid
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Two open-case totals on one screen: the Programs tile says 15,858 and the nav badge says 15,868 Openbug frontend maui-pilot
Difficulty 2/5 1-3 hours Newbie friendliness 72/100