Why is precinctOptions.includeCore always false?

Open
  • Is something wrong?
#150 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

  • #151 by @lijialiang — closed without merging

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript
Domain
tooling

Research direction

Start at index.js around line 85 and trace how detectiveConfig is converted into precinctOptions. Verify the includeCore setting is preserved when dependency-tree analysis runs, then check the existing test suite for coverage of core dependencies such as url and querystring. Done means enabling detectiveConfig.includeCore makes those dependencies appear in the resulting tree.

Written by the indexing model from the issue text.

Description

When using it, I found that I could not find any dependencies like url, querystring, etc. Even though detectiveConfig.includeCore is set to true, it does not work.

A look at the source code shows that precinctOptions.includeCore is always set to false.

https://github.com/dependents/node-dependency-tree/blob/d3a0cd3551b4bf1508e857d1123d0f287f6ec121/index.js#L85

Dominant language
JavaScript
Stars
776
Forks
82
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dependents/node-dependency-tree

All issues in dependents/node-dependency-tree

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.