Typescript 7

Open
  • Is something wrong?
#5,173 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript, vim
Domain
devtools

Research direction

The problem is the tsserver linter and fixer in ALE, which still launches a tsserver binary that TypeScript 7 removed. Start by finding where ALE defines the tsserver command, then check whether the tsc --lsp --stdio invocation from the issue can replace it, and run :ALEInfo on a TypeScript 7 project to confirm the executable check. Done means linting and fixing work on TypeScript 7 without breaking TypeScript 6 projects.

Written by the indexing model from the issue text.

Description

bug

Information

VIM version

NVIM v0.12.5
Build type: RelWithDebInfo

Operating System: Arch Linux

What went wrong

Updating a project from typescript 6 to typescript 7 causes the tsserver ALE linter/fixer to stop working.

My understanding is this is because typescript 7 has removed the tsserver binary and incorporated the functionality into tsc. So you are supposed to run tsc --lsp --stdio (source).

I guess its meant to be a drop-in, but I was unable to verify that. I tried creating a tsserver script that just execd that command, but that didn't work. ALE found it and executed it, but no linting/fixing occurred.

Reproducing the bug

Have a typescript 6 project using tsserver successfully. Upgrade the project to typescript 7.

:ALEInfo

I can provide this if necessary, but I downgraded my project now so I would have to re-upgrade to do so. The only relevant bit was that it showed an executable check failure for tssever, as I'd expect.

Dominant language
Vim Script
Stars
14k
Forks
1.5k
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dense-analysis/ale

All issues in dense-analysis/ale

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.