[Biome] No longer working with v2

Open
  • Is something wrong?
#4,998 12 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript, vim
Domain
tooling

Research direction

Start by reproducing the failure with the reported ALE commit, Vim version, vimrc settings, and biome lint --config-path ~/.config/biome/biome.json advertisement.ts command. Compare the working command with how ALE invokes Biome for TypeScript, including the ale_biome_lsp_project_root setting; done means Biome v2 linting works in Vim with the documented configuration.

Written by the indexing model from the issue text.

Description

bug

ALE commit: edccdfa9efb7a4b37fb846e55b2137b55275d39e
Vim: 9.1.1497-1

Since Biome version 2, the linter no longer works for me although I updated the configuration file. Running biome lint --config-path ~/.config/biome/biome.json advertisement.ts works. However, in Vim it does not.

Relevant sections from my vimrc.

let g:ale_linters =
            \{
            \    'bib': ['bibclean'],
            \    'cpp': ['clangtidy'],
            \    'cmake': ['cmake_lint'],
            \    'css': ['stylelint'],
            \    'desktop': ['desktop_file_validate'],
            \    'gitcommit': ['gitlint'],
            \    'html': ['htmlhint', 'tidy'],
            \    'java': ['javac', 'pmd'],
            \    'json': ['jq'],
            \    'mail': [],
            \    'make': ['checkmake'],
            \    'markdown': ['markdownlint'],
            \    'PKGBUILD': ['shell', 'shellcheck'],
            \    'po': ['msgfmt'],
            \    'python': ['bandit', 'mypy', 'pycodestyle', 'pydocstyle', 'pyflakes', 'pyright', 'ruff', 'vulture'],
            \    'sh': ['shell', 'shellcheck'],
            \    'systemd': ['systemd_analyze'],
            \    'tex': ['chktex'],
            \    'text': [],
            \    'toml': [],
            \    'typescript': ['biome'],
            \    'vim': ['vint'],
            \    'xml': ['xmllint'],
            \    'yaml': ['yamllint'],
            \    'zsh': ['shell', 'shellcheck']
            \}

""" typescript
let g:ale_biome_lsp_project_root = $XDG_CONFIG_HOME . '/biome/' " Commenting out does still not work.

Consider that I tried to comment out the setting ale_biome_lsp_project_root.

@redbmk Does it still work for you? Do you know a solution? Am I doing something wrong?

Dominant language
Vim Script
Stars
14k
Forks
1.5k
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dense-analysis/ale

All issues in dense-analysis/ale

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.