docs(kind_sets): Float2 is never a (float) cast
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 85/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust
- Domain
- documentation
Research direction
Navigate to big-code-analysis-ast/src/macros/kind_sets.rs lines 480-481, where the incorrect comment claims Float2 represents a (float) cast. Update the comment to remove the false claim, then run make self-scan-write-baseline-headroom to refresh the project baseline as required by the file's line limit. The task is done once the comment is accurate and the baseline check passes.
Written by the indexing model from the issue text.
Description
Summary
big-code-analysis-ast/src/macros/kind_sets.rs:480-481 says Float2
(52) is "the float type keyword of a parameter type or a
(float) cast". The second half is false. Found in the #1474 review.
Evidence
Every PHP cast spelling — (float), (double), (real), (integer),
(string) — parses to a childless cast_type (262) and emits no
keyword node at all (bca dump --no-config on each). Float2 appears
only under a primitive_type wrapper. The wrong sentence now sits
three lines above the correct (string)-cast claim #1474 added, and
contradicts getter/php.rs:241.
Constraint
The file sits exactly at its .bca-baseline.toml loc.sloc limit
(1357), and no accurate wording fits the same six comment lines, so the
one-line repair needs make self-scan-write-baseline-headroom in the
same commit.
Related
- #1462 — where the
Float2exclusion rationale was written. - #1474 — the neighbouring
String2fix.
- Dominant language
- Rust
- Stars
- 32
- Forks
- 3
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 49
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dekobon/big-code-analysis
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
dekobon/big-code-analysis#1644 ·
Maintainers usually reply within 1 day
-
bug python vcs
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
dekobon/big-code-analysis#1624 · 1 comment ·
Maintainers usually reply within 1 day
-
cli documentation
Difficulty 1/5 Under an hour Newbie friendliness 85/100
dekobon/big-code-analysis#1485 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
dekobon/big-code-analysis#1458 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 85/100
dekobon/big-code-analysis#1444 ·
Maintainers usually reply within 1 day
All issues in dekobon/big-code-analysis
Similar issues
-
documentation priority:p2 type:chore
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
facebookincubator/scrut#60 ·
-
dispatch:sol-high documentation
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
carrick-sh/carrick#768 · 1 comment ·
Maintainers usually reply within 1 day
-
correctness postgres tursopg
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
tursodatabase/turso#10442 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
ankitects/anki#5864 · 1 reaction ·
Maintainers usually reply within 2 days