Add validation for emscriptenLinkFlags

Open
#532 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Domain
build-system

Research direction

Read Emscripten's src/settings.js, linked in the issue, to review the supported settings, then locate where extender processes emscriptenLinkFlags. Done means invalid flag forms are rejected and flags meeting the stated X=Y minimum are accepted.

Written by the indexing model from the issue text.

Description

enhancement web

Currently we accept link flags in any form. As a bare minimum we should check that the flag satisfies at least "X=Y".

All the flags that are supported is presented here: https://github.com/emscripten-core/emscripten/blob/main/src/settings.js

Dominant language
Java
Stars
67
Forks
25
Avg merge
1d 1h
Merged PRs (30d)
16

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from defold/extender

All issues in defold/extender

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.