macOS signing follow-ups: source-built agent identity, plist validation, secret scope
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 42/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- github-actions, go, macos
- Domain
- build-system, devops, security
Research direction
Read the macOS launchd plist in deployment/macos/, the make build-metal-agent and make install-metal-agent targets, and internal/machoplist with scripts/macos-sign_test.sh. Start by checking the plist identity and validatePlist behavior, then inspect the GoReleaser signing environment and local fallback. Done means all four follow-ups are addressed and the fallback is exercised with a real build.
Written by the indexing model from the issue text.
Description
Follow-ups from the review of #2233 (signing and notarizing the macOS binaries). None of these blocks #2233.
make install-metal-agentinstalls a plist naming a bundle identifier the binary lacks. The launchd plist indeployment/macos/now carriesAssociatedBundleIdentifiers=dev.llmkube.metal-agent, butmake build-metal-agentembeds no Info.plist and keeps the linker's ad-hoc signature, so a source-built agent has a different identifier. Either embed the plist and sign ad-hoc in the Makefile target (withcmd/machoplistandcodesign), or drop the key from the plist the Makefile installs.validatePlistaccepts content after the root element.internal/machoplistchecks that the plist decodes, but a template with trailing bytes after</plist>passes. Reject anything but whitespace after the root element.- The signing certificate reaches the whole GoReleaser process.
MACOS_SIGN_P12andMACOS_SIGN_PASSWORDare in the GoReleaser step's environment, so every hook and build command can read them, not justhack/macos-sign.sh. Passing them only to the hook (for example through a file the step writes with 0600 and the hook reads) would narrow that. The notary key no longer reaches GoReleaser. - The
go run ./cmd/machoplistfallback is not exercised by a release. The release always setsMACHOPLIST; the fallback runs only locally.scripts/macos-sign_test.shchecks its arguments with a stubbedgo, but not that it builds and embeds for real.
- Dominant language
- Go
- Stars
- 232
- Forks
- 37
- Avg merge
- 21h 42m
- Merged PRs (30d)
- 244
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from defilantech/LLMKube
-
component/metal-agent documentation
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
defilantech/LLMKube#2581 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
defilantech/LLMKube#2578 ·
Maintainers usually reply within 1 day
-
documentation helm priority/low size/small
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
defilantech/LLMKube#2420 ·
Maintainers usually reply within 1 day
-
component/metal-agent enhancement priority/low size/medium
Difficulty 4/5 3-5 days Newbie friendliness 48/100
defilantech/LLMKube#2597 ·
Maintainers usually reply within 1 day
-
[BUG] Docs and comments describe InsufficientMemory only as a start refusal, but a serving engine can now carry itPossibly taken @defilan-agent claimed this today. Openbug component/metal-agent documentation priority/low size/small
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
defilantech/LLMKube#2596 ·
Maintainers usually reply within 1 day
All issues in defilantech/LLMKube
Similar issues
-
☢️ Bug v3
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
area/import-export area/projects concern/ux
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
go-vikunja/vikunja#4455 · 1 comment ·
Maintainers usually reply within 2 days
-
Dependabot PRs no longer merge automaticallyPossibly taken @dwisiswant0 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
projectdiscovery/urlfinder#160 ·
Maintainers usually reply within 1 day
-
database
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
chnm/legal-modernism#450 ·
Maintainers usually reply within 1 day
-
tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day