[STORY] ripwire as an interactive Foreman agent tool

Open
#1,905 0 comments 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@Defilan is already working on this.

Since Sep 26, 2026.

  • #1909 by @Defilan — closed without merging

Assessment

This issue has not been assessed yet.

Description

area/foreman enhancement size/large

Goal

A Foreman agent can call ripwire mid-task for callers, blast radius, and tests-to-run, as a whitelisted tool.

Definition of done

  • Observable: an Agent with ripwire in spec.tools can invoke it and receive ripwire output; a model-supplied argument cannot escape the fixed verb set or the workspace.
  • Negative: an Agent without ripwire in its whitelist gets ErrToolNotInWhitelist, unchanged.

Scope

  • A new tool in pkg/foreman/agent/tools implementing the Tool interface, exposing a fixed verb set (for, callers, impact, tests).
  • Wire the name into tools/buildall.go and tools/catalog/catalog.go (the TestBuildAllMatchesCatalog drift guard holds both in step).
  • Tests: dispatch per allowed verb; argv construction rejects an unexpected flag; output is capped; timeout enforced.

Out of scope

  • Any edit verbs (ripwire --apply). Read-only verbs only.

Consumers and surfaces touched

  • The agent tool surface and the Agent admission webhook's spec.tools catalog. The model controls tool args, so argv is a fixed array, no shell, with a hard timeout and an output cap.

Verification

make fmt vet lint test
# tool dispatched with each allowed verb; output capped
# argv construction rejects an unexpected flag

Falsification

  • Edit: pass model args through a shell instead of an argv array.
  • Expected failure: the injection/escaping test FAILS.
  • Edit: drop ripwire from canonicalToolNames.
  • Expected failure: TestBuildAllMatchesCatalog FAILS.

Risks

  • Model-controlled args on a third-party binary is an adversarial surface (see AGENTS.md security-sensitive invariants). Keep read-only, fixed-verb, argv-array, timeout, output cap.
Dominant language
Go
Stars
232
Forks
37
Avg merge
21h 42m
Merged PRs (30d)
244

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from defilantech/LLMKube

All issues in defilantech/LLMKube

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.