Only pass --ignore-addr-diffs to asm-differ for aarch64
Maintainers usually reply within 1 day
Nobody has claimed this yet.
- #2148 by @sloemo01 — closed without merging
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- python
- Domain
- backend, reverse-engineering
Research direction
Read backend/coreapp/diff_wrapper.py around line 114, where the issue says the argument is passed to asm-differ. Check how the selected architecture is represented there and consult the linked asm-differ issue for the arm32 behavior. Done means --ignore-addr-diffs is passed for aarch64 only, not arm32 or other architectures.
Written by the indexing model from the issue text.
Description
For arm32, --ignore-addr-diffs is harmful, because it silences diffs in bl symbol names. (https://github.com/simonlindholm/asm-differ/issues/225)
For aarch64, it is helpful because the typical workflow diffs linked files against unlinked ones, and then addr diffs are expected to be ignored.
For all other architectures, the flag is unimplemented by asm-differ.
The argument gets passed here: https://github.com/decompme/decomp.me/blob/33ca188cfe62ffa03299f7a1bd7883cd63f8bee2/backend/coreapp/diff_wrapper.py#L114
- Dominant language
- TypeScript
- Stars
- 622
- Forks
- 159
- Avg merge
- 10h 18m
- Merged PRs (30d)
- 34
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from decompme/decomp.me
-
download.py fails to consider errors failuresMay be free again @apurva1094 claimed this 31 days ago, and no pull request is open. Openbug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
decompme/decomp.me#2118 · 1 comment ·
Maintainers usually reply within 1 day
-
ux
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
-E output windowOpenbackend frontend
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
decompme/decomp.me#223 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
Maintainers usually reply within 1 day
All issues in decompme/decomp.me
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
appandflow/stim#5258 ·
Maintainers usually reply within 1 day
-
area/docs framework/hugo help wanted language/markdown
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 68/100
lingdojo/kana-dojo#33660 · 1 comment · 5 reactions ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
drizzle-team/drizzle-orm#6639 ·
Maintainers usually reply within 4 days
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100