Don't hardcode colors
@MawiraIke is already working on this.
Since May 18, 2021.
Assessment
This issue has not been assessed yet.
Description
For example: https://github.com/Day8/re-com/blob/master/src/re_com/modal_panel.cljs#L49 and https://github.com/Day8/re-com/blob/master/src/re_com/splits.cljs#L120
The components aren't compatible with bootstrap dark themes because of this.
IMO colors shouldn't be hardcoded. A possible middle ground could be to use classes.
(Re-com already needs its own CSS anyway.)
- Dominant language
- Clojure
- Stars
- 824
- Forks
- 143
- Avg merge
- 3m
- Merged PRs (30d)
- 1
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from day8/re-com
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
-
Scrolling broken after upgrade from v2.23.1 to v2.24.0May be free again @mike-thompson-day8 claimed this 176 days ago, and no pull request is open. Open
-
Use the `:parts` and `:theme` system for all existing componentsMay be free again @kimo-k claimed this 406 days ago, and no pull request is open. Open
-
title: forces margins inconsistanlyMay be free again @Gregg8 claimed this 721 days ago, and no pull request is open. Openbug
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
Similar issues
-
.Needs Triage Administration/People Priority:P2 Type:Bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
metabase/metabase#85503 · 1 comment ·
Maintainers usually reply within 1 day
-
bug: Editing the L value in HSL mode resets H and S to 0Possibly taken @makesomethingshit claimed this today. Openneeds triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
pgwire tokens-reqd
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day
-
Evals take an extra 40ms each on Linux, since the server doesn't set TCP_NODELAYPossibly taken @bbatsov claimed this 4 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
software-mansion/starknet-jvm#641 ·