Revamp the logging block override mechanism
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- objective-c
- Domain
- security
Research direction
Start by reviewing the Objective-C +[TrustKit setLoggerBlock:] API and how logger blocks are applied across singleton and non-singleton TrustKit instances. The issue does not name implementation files or tests, so locate the logger configuration and instance-construction paths first; done means the override behavior and API semantics are consistent for both usage modes.
Written by the indexing model from the issue text.
Description
In version 1.5.0, the + [TrustKit setLoggerBlock:] method does not really make sense anymore now that TrustKit can be used in non-singleton mode.
The logger block will always be applied to all TrustKit instances, although the way the API is designed (as a class method) makes it look like it only applies to the singleton instance. This is confusing and inconsistent.
- Dominant language
- Objective-C
- Stars
- 2.1k
- Forks
- 381
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from datatheorem/TrustKit
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
datatheorem/TrustKit#360 ·
-
enhancement help wanted
Difficulty 4/5 3-5 days Newbie friendliness 35/100
datatheorem/TrustKit#341 · 1 comment ·
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 48/100
datatheorem/TrustKit#340 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
datatheorem/TrustKit#333 · 2 comments · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 28/100
datatheorem/TrustKit#330 · 1 comment ·
All issues in datatheorem/TrustKit
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
MaikuB/flutter_appauth#683 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
flutter-webrtc/flutter-webrtc#2216 ·
Maintainers usually reply within 1 day
-
Xcode 27 UpdateOpen
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
hackiftekhar/IQKeyboardManager#2184 ·
-
RemoteConfigProperty stays stale when activation removes a remote keyPossibly taken @paulb777 claimed this 1 day ago. Openapi: remoteconfig
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
firebase/firebase-ios-sdk#16816 · 1 comment ·
Maintainers usually reply within 1 day