TrustKit-Android can’t support multi <domain> under the same <domain-config>

Open
#78 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
android, java
Domain
mobile, security

Research direction

Start with trustkit/src/androidTest/res/xml/network_security_config.xml, the test resource referenced in the issue, and review its existing multi-domain cases. Add coverage for multiple domains under one domain-config, then verify that pinning applies to google.com, yahoo.com, and verizon.com rather than only the last domain.

Written by the indexing model from the issue text.

Description

Is your feature request related to a problem? Please describe.
TrustKit-Android can’t support multi under the same
This means it only deploys SSL public key pinning at the last domain, for example

<domain-config>
  <domain includeSubdomains="true">google.com</domain>
  <domain includeSubdomains="true">yahoo.com</domain>
  <domain includeSubdomains="true">verizon.com</domain>
<pin-set>
    <pin digest="SHA-256">AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=</pin>
    <pin digest="SHA-256">YLh1dUR9y6Kja30RrAn7JKnbQG/uEtLMkBgFF2Fuihg=</pin>
  </pin-set>
</domain-config>

TrustKit only verifies the domain verizon.com’s certificate chain. Neither google.com nor yahoo.com

Describe the solution you'd like
Because TrustKit Android works by extending the Android N Network Security Configuration, it is good to support multi under the same

Describe alternatives you've considered
If we want to enable SSL pinning to multi domain, even the same certificate chain, we need to separate the domain-config

<domain-config>
  <domain includeSubdomains="true">google.com</domain>
  <pin-set>
    <pin digest="SHA-256">AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=</pin>
    <pin digest="SHA-256">YLh1dUR9y6Kja30RrAn7JKnbQG/uEtLMkBgFF2Fuihg=</pin>
  </pin-set>
</domain-config>
<domain-config>
  <domain includeSubdomains="true">yahoo.com</domain>
  <pin-set>
    <pin digest="SHA-256">AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=</pin>
    <pin digest="SHA-256">YLh1dUR9y6Kja30RrAn7JKnbQG/uEtLMkBgFF2Fuihg=</pin>
  </pin-set>
</domain-config>
<domain-config>
  <domain includeSubdomains="true">verizon.com</domain>
  <pin-set>
    <pin digest="SHA-256">AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=</pin>
    <pin digest="SHA-256">YLh1dUR9y6Kja30RrAn7JKnbQG/uEtLMkBgFF2Fuihg=</pin>
  </pin-set>
</domain-config>

Additional context
We can refer its test cases:
https://github.com/datatheorem/TrustKit-Android/blob/master/trustkit/src/androidTest/res/xml/network_security_config.xml

Dominant language
Java
Stars
604
Forks
90
Avg merge
1h 29m
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from datatheorem/TrustKit-Android

All issues in datatheorem/TrustKit-Android

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.