Volley and Truskit blocking other domains

Open
#92 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
mobile-dev, security

Research direction

Start with network_security_config.xml and reproduce a Volley request to a domain other than prod.com or preprod.com. Trace how TrustKit and Volley handle domains outside the two domain-config blocks; done means the configured domains remain pinned while requests to other domains are no longer blocked.

Written by the indexing model from the issue text.

Description

Hello,

I have implemented certificate pinning with Trustkit, Volley and the config file network_security_config.xml, which look like :

<network-security-config>
    <domain-config>
        <domain includeSubdomains="true">preprod.com</domain>
        <pin-set expiration="2050-12-12">
            <pin digest="SHA-256">AAAAAAAAAAAAA</pin>
            <pin digest="SHA-256">BBBBBBBBBBBBB</pin>
        </pin-set>
        <trustkit-config enforcePinning="true"/>
    </domain-config>
    <domain-config>
        <domain includeSubdomains="true">prod.com</domain>
        <pin-set expiration="2050-12-12">
            <pin digest="SHA-256">CCCCCCCCCCCC</pin>
            <pin digest="SHA-256">DDDDDDDDDDDD</pin>
        </pin-set>
        <trustkit-config enforcePinning="true"/>
    </domain-config>
</network-security-config>

It is working perfectly when I am calling urls like .prod.com/ or .preprod.com/ but when I want to call another domain it is blocking everything. Is there a way to fix the configuration ?

Thanks

Dominant language
Java
Stars
604
Forks
90
Avg merge
1h 29m
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from datatheorem/TrustKit-Android

All issues in datatheorem/TrustKit-Android

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.