Enforce pinning not respected in Android 5.0

Open
#59 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
android, java
Domain
mobile, security

Research direction

Start with the supplied network-security-config and reproduce the pinning failure on Android 5.0, comparing it with Android 8.0. Trace how enforcePinning="false" is handled when certificate validation fails, then verify that failed validation is reported without blocking traffic while the Android 8.0 behavior remains unchanged.

Written by the indexing model from the issue text.

Description

Describe the bug
When using the TrustKit on 5.0 device, I am getting javax.net.ssl.SSLHandshakeException: Certificate validation failed for ...
When checking the log, it has correct parameters:
E/CERT ERROR: "include-subdomains": false,
E/CERT ERROR: "enforce-pinning": false,
E/CERT ERROR: "validation-result": 2,

These are respected on Android 8.0
The CERT ERROR: "validated-certificate-chain": contains the correct certificate, that is in the xml file and served-certificate-chain": are also same. known-pins are also correct.

To Reproduce
I can only reproduce on the 5.0 device, works correctly in emulator
I am not including the domain, because it is accessible only on private network

Expected behavior
It shouldn't fail and if it fails, it shouldn't block the traffic with enforce-pinning set to false (works well on other devices)

TrustKit configuration

domain.com f3n+wu1f9Z4QvyZZAItVF55NNBJpDFf8f68P/uLyRHA= BnGNbPrwbfsIyAu+IjeZ/nAOloLMEVQXNAyQse4u/nA= subdomain.domain.com KZOAUwc92hHmVhuD8TaDaMp3yLKF1Y6vaurRigRS8w8= EjGCjEFfzshXkT1QHH0fVfCjhy5CqZkB3TxXYRrokUI=

App details:

  • App target SDK: 28
  • App language:Java
  • Android version to reproduce the bug: 5.0
Dominant language
Java
Stars
604
Forks
90
Avg merge
1h 29m
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from datatheorem/TrustKit-Android

All issues in datatheorem/TrustKit-Android

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.