--sandbox and --approve-for-me cannot be combined, and the help text implies they can

Open Beginner friendly
#7 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
shell
Domain
cli

Research direction

Start by reading the genie exec --help option definition and the argument validation that rejects --sandbox with --approve-for-me; the payload does not name their files. Confirm the current help text and reproduce with the command in the issue. Done when the help explains that --approve-for-me sets the workspace-write sandbox and cannot be combined with -s or --sandbox, or the stated combination is accepted.

Written by the indexing model from the issue text.

Description

Release version

v0.3.0

What happened?

--sandbox and --approve-for-me cannot be used together, but the help text suggests they fit together.

$ genie exec -s workspace-write --approve-for-me "noop"
error: the argument '--sandbox <SANDBOX_MODE>' cannot be used with '--approve-for-me'

The help text for --approve-for-me says:

Route approval requests through automatic review using the workspace-write sandbox

A reader takes this to mean you should pair it with -s workspace-write, which then fails.

Expected: the help text for --approve-for-me says that it sets the workspace-write sandbox itself and cannot be combined with -s or --sandbox. Accepting -s workspace-write as a no-op would also work.

Steps to reproduce
  1. Run genie exec -s workspace-write --approve-for-me "noop".
  2. The command exits with the error above.
  3. Run genie exec --help and read the --approve-for-me entry.
Environment

macOS (Apple silicon), Genie Code CLI installed with install.sh.

Dominant language
No language data
Stars
13
Forks
1
Avg merge
35m
Merged PRs (30d)
1

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from databricks/genie-code-cli

All issues in databricks/genie-code-cli

Similar issues

More CLI issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.