[bug] IntegrityCheck --no-stamp still writes (workers do not get the flag)

Open
#2,810 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 5 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
node.js, typescript
Domain
tooling

Research direction

Start with LIFEOS/TOOLS/IntegrityCheck.ts: check the header claim that --no-stamp and --section runs write nothing, then trace runWorker() to see that workers get --run-entry and --verbose but not --no-stamp or --accept-drop. Guard the output-coverage emit, the record-coverage writeEventOnce() calls and the plugin temp-folder write behind the read-only flags. Done when a --no-stamp run writes nothing in every lane and no-ledger installs report 'not measured'.

Written by the indexing model from the issue text.

Description

What happened

IntegrityCheck --no-stamp still writes (workers do not get the flag)

Summary

LifeOS 8.761.0. The header of LIFEOS/TOOLS/IntegrityCheck.ts says "--no-stamp and --section runs write nothing at all". Four things break that:

  1. runWorker() starts each worker with --run-entry <i> (and --verbose), not with --no-stamp. Inside a worker noStamp is therefore false: the output-coverage lane emits its Vigil event on every --no-stamp run, and the layer-one lane can rewrite its snapshot.
  2. A --section output-coverage run emits the same event (the emit has no guard for --section).
  3. The send-gate audit lane can emit events and the record-coverage lane calls writeEventOnce() whatever the flag says; the plugin lane writes a temporary folder.
  4. --accept-drop is not passed to the workers either, so a concurrent full run cannot accept a drop.

Related: on an install with no output ledger file (the recorder hook is not in the public release), the reconciler's event reads "Output coverage 0%, N escapes" at severity medium on every run. The number cannot change there.

Suggested fix: pass the flags to the workers, guard each emit with the read-only flags, and report "not measured" while no ledger file exists.

Details

  • Kind: bug
  • LifeOS version: 8.761.0

Filed with the LifeOS /feedback command. The reporter approved this exact text before it was sent; paths, secrets and personal details were stripped locally.

Dominant language
TypeScript
Stars
19.9k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from danielmiessler/LifeOS

All issues in danielmiessler/LifeOS

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.