LifeOSHooks/RichFormat types: setup names only claude-code.d.ts (claude-code-tools.d.ts also needed), mod-types skips when declarations are absent, RichFormat test fails tsc on 2.1.322

Open
#2,778 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 5 days

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
58/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
typescript

Research direction

Start with LIFEOS/TOOLS/IntegrityCheck.ts and checkModTypes, then review the named setup docs and type declarations in skills/LifeOSHooks and skills/RichFormat. Reproduce the reported tsc failures on Claude Code 2.1.322 with the stated declaration files. Done when setup names both required files, mod-types detects installed mods missing declarations, and the RichFormat test typechecks.

Written by the indexing model from the issue text.

Description

LifeOS 8.761.0, Claude Code 2.1.322, Linux. Both mods (LifeOSHooks, RichFormat) loaded from the skills folder.

1. Setup names one declaration file; the hooks module needs two

skills/LifeOSHooks/SKILL.md (§ After a Claude Code update), skills/LifeOSHooks/Setup.md and the mod-types fix text in LIFEOS/TOOLS/IntegrityCheck.ts name only claude-code.d.ts. With only that file in .claude/types/, tsc -p skills/LifeOSHooks reports 32 errors, all in hooks/LifeOSHooks.ts, for example:

  • TS2367: This comparison appears to be unintentional because the types '"Agent" | "AskUserQuestion" | "Glob" | ...' and '"Bash"' have no overlap (line 1270)
  • TS2339: Property 'command' does not exist on type 'never' (line 1373)

BuiltinToolInputs is empty until the engine's second file, claude-code-tools/index.d.ts, merges into it. Copying .claude-plugin/types/claude-code-tools/index.d.ts (which the engine lays beside the mod) to .claude/types/claude-code-tools.d.ts makes tsc exit 0 on 2.1.322.

Suggested fix: name both files wherever the declarations step is described. The engine's copies in .claude-plugin/types/ are also an easier source than the plugin-authoring skill folder; skills/RichFormat/Setup.md already points there.

2. mod-types reports "no function-hooks mods installed" when both are installed

checkModTypes recognises a mod by the presence of types/claude-code.d.ts or .claude/types/claude-code.d.ts. The release ships neither, so a fresh install shows ✓ mod-types skipped — no function-hooks mods installed while both mods are loaded, and the check that should flag declarations missing or stale for the running build never runs.

Suggested fix: find mods by hooks/hooks.json carrying modules (or by the plugin manifest), and report missing declarations as a non-blocking finding.

3. RichFormat tests/engine.test.tsx does not typecheck on 2.1.322

With both declaration files in skills/RichFormat/types/, tsc -p skills/RichFormat reports 4 × TS2345 at lines 38, 49, 63 and 89: Argument of type 'Engine' is not assignable to parameter of type '{ prompt: { compose: (e: unknown) => Promise<unknown>; }; }'. The helper interactive($: { prompt: { compose: (e: unknown) => Promise<unknown> } }, on) declares a parameter wider than PromptComposeInput, which strict function types reject. Typing $ as Engine (or compose: (e: never) => Promise<unknown>) clears it. hooks/ itself is clean.

Dominant language
TypeScript
Stars
19.9k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from danielmiessler/LifeOS

All issues in danielmiessler/LifeOS

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.